Method call is provided 2 parameters, but the method signature uses 1 parameters

AccessManager.php
$route = $this->routeProvider->getRouteByName($route_name, $parameters);

CommentFileSizeAuthor
#6 interdiff-3102980-4-6.txt833 bytesnathaniel
#6 accessmanager_getroutebyname-3102980-6.patch2.39 KBnathaniel
#4 accessmanager_getrouteby_name-3102980-4.patch1.79 KBhardik_patel_12
#4 interdiff-3102980-2-4.txt1.17 KBhardik_patel_12
#2 accessmanager_getroutebyname-3102980-2.patch769 bytesnathaniel

Comments

Nathaniel created an issue. See original summary.

nathaniel’s picture

nathaniel commented
Status: Active » Needs review
StatusFileSize
new accessmanager_getroutebyname-3102980-2.patch769 bytes

Status: Needs review » Needs work

The last submitted patch, 2: accessmanager_getroutebyname-3102980-2.patch, failed testing. View results

hardik_patel_12’s picture

hardik_patel_12 commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-3102980-2-4.txt1.17 KB
new accessmanager_getrouteby_name-3102980-4.patch1.79 KB

Kindly review a new patch

Status: Needs review » Needs work

The last submitted patch, 4: accessmanager_getrouteby_name-3102980-4.patch, failed testing. View results

nathaniel’s picture

nathaniel commented
Status: Needs work » Needs review
StatusFileSize
new accessmanager_getroutebyname-3102980-6.patch2.39 KB
new interdiff-3102980-4-6.txt833 bytes
hardik_patel_12’s picture

hardik_patel_12 commented

Thank you @Nathaniel. Above patch works fine.

hardik_patel_12’s picture

hardik_patel_12 commented
Status: Needs review » Reviewed & tested by the community

  • catch committed a7f702a on 9.0.x 
    Issue #3102980 by Nathaniel, Hardik_Patel_12: AccessManager...

  • catch committed fc0b41d on 8.9.x 
    Issue #3102980 by Nathaniel, Hardik_Patel_12: AccessManager...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

The documentation is actually wrong for that method, opened #3110104: Incorrect documentation for RouteProvider::getRouteByName().

Committed a7f702a and pushed to 9.0.x and 8.9.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.