Problem/Motivation

SF4.4 beta 1 was released on 2019-11-12. We should update 9.0 to the beta prior to tagging an alpha if possible.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Drupal 9.0.x now includes Symfony 4.4.0-beta2

CommentFileSizeAuthor
#9 3094007-9.patch60.48 KBalexpott
#6 3094007-6.patch44.83 KBjibran
#6 interdiff-963bc7.txt16.21 KBjibran
#2 3094007-2.drupal.patch43.47 KBmikelutz

Comments

mikelutz created an issue. See original summary.

mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
commented
Status: Active » Needs review
StatusFileSize
new 3094007-2.drupal.patch43.47 KB

Trying the instructions from https://www.drupal.org/node/3089540

Package operations: 1 install, 24 updates, 1 removal
  - Removing symfony/error-renderer (4.4.x-dev fca8c29)
  - Updating symfony/class-loader (v3.4.32 => v3.4.34): Loading from cache
    Cleaning: symfony/class-loader
  - Updating symfony/service-contracts (v1.1.7 => v2.0.0): Loading from cache
  - Downgrading symfony/console (4.4.x-dev aa43e86 => v4.4.0-BETA1): Loading from cache
    Cleaning: symfony/console
  - Downgrading symfony/dependency-injection (4.4.x-dev 556a6b3 => v4.4.0-BETA1): Loading from cache
    Cleaning: symfony/dependency-injection
  - Updating symfony/mime (v4.3.5 => v4.3.7): Loading from cache
  - Downgrading symfony/http-foundation (4.4.x-dev 002d69d => v4.4.0-BETA1): Loading from cache
    Cleaning: symfony/http-foundation
  - Downgrading symfony/event-dispatcher (4.4.x-dev c73bdef => v4.4.0-BETA1): Loading from cache
    Cleaning: symfony/event-dispatcher
  - Installing symfony/var-dumper (v5.0.0-BETA1): Loading from cache
  - Downgrading symfony/debug (4.4.x-dev 25fd3ba => v4.4.0-BETA1): Loading from cache
    Cleaning: symfony/debug
  - Downgrading symfony/error-handler (dev-master b9953ac => v4.4.0-BETA1): Loading from cache
  - Downgrading symfony/http-kernel (4.4.x-dev a228a47 => v4.4.0-BETA1): Loading from cache
    Cleaning: symfony/http-kernel
  - Downgrading symfony/routing (4.4.x-dev 9e472b4 => v4.4.0-BETA1): Loading from cache
    Cleaning: symfony/routing
  - Downgrading symfony/serializer (4.4.x-dev c7e56d8 => v4.4.0-BETA1): Loading from cache
    Cleaning: symfony/serializer
  - Updating symfony/translation-contracts (v1.1.7 => v2.0.0): Loading from cache
  - Downgrading symfony/translation (4.4.x-dev 01a25cb => v4.4.0-BETA1): Loading from cache
    Cleaning: symfony/translation
  - Downgrading symfony/validator (4.4.x-dev 137d3f6 => v4.4.0-BETA1): Loading from cache
    Cleaning: symfony/validator
  - Downgrading symfony/process (4.4.x-dev 5ec7407 => v4.4.0-BETA1): Loading from cache
    Cleaning: symfony/process
  - Downgrading symfony/yaml (4.4.x-dev 8caed6e => v4.4.0-BETA1): Loading from cache
    Cleaning: symfony/yaml
  - Downgrading symfony/css-selector (4.4.x-dev 1f8fa58 => v4.4.0-BETA1): Loading from cache
    Cleaning: symfony/css-selector
  - Downgrading symfony/phpunit-bridge (4.4.x-dev ed7630d => v4.4.0-BETA1): Loading from cache
    Cleaning: symfony/phpunit-bridge
  - Downgrading symfony/filesystem (4.4.x-dev f903e39 => v4.4.0-BETA1): Loading from cache
    Cleaning: symfony/filesystem
  - Downgrading symfony/finder (4.4.x-dev 30898bb => v4.4.0-BETA1): Loading from cache
    Cleaning: symfony/finder
  - Downgrading symfony/lock (4.4.x-dev 03d9a1d => v4.4.0-BETA1): Loading from cache
  - Downgrading symfony/dom-crawler (4.4.x-dev 0961866 => v4.4.0-BETA1): Loading from cache
    Cleaning: symfony/dom-crawler
  - Downgrading symfony/browser-kit (4.4.x-dev eeade40 => v4.4.0-BETA1): Loading from cache
    Cleaning: symfony/browser-kit

Status: Needs review » Needs work

The last submitted patch, 2: 3094007-2.drupal.patch, failed testing. View results

aaronmchale’s picture

aaronmchale
Primary language English
Location Edinburgh, Scotland
commented
Issue summary: View changes

IS Summary headings were duplicated

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Title: Update the 9.0.x branch to Symfony 4.4-beta1 » Update the 9.0.x branch to Symfony 4.4-beta2

beta2 now.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-963bc7.txt16.21 KB
new 3094007-6.patch44.83 KB

This will address most of the warnings.

Status: Needs review » Needs work

The last submitted patch, 6: 3094007-6.patch, failed testing. View results

berdir’s picture

berdir
Primary language German
Location Switzerland
commented 
+++ b/core/tests/Drupal/Tests/Listeners/DeprecationListenerTrait.php
@@ -199,6 +199,9 @@ public static function getSkippedDeprecations() {
+      'The "Symfony\Component\HttpKernel\Event\GetResponseForExceptionEvent::getException()" method is deprecated since Symfony 4.4, use "getThrowable()" instead.',

Considering that we don't need to be compatible with <4.4 in D9, we should be able to instead fix our code?

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs work » Needs review
StatusFileSize
new 3094007-9.patch60.48 KB

Here's a fix for #8. We can't avoid the other deprecation because this is caused by a call from any dependency - \Behat\Mink\Driver\BrowserKitDriver::getText() - and it's not been fixed yet in HEAD - https://github.com/minkphp/MinkBrowserKitDriver/blob/98cdff187a3c3759afb...

mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
commented

+1 on the approach above. I would RTBC if I hadn't made the original patch.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Reviewed & tested by the community

Agreed, looks good to me as well. great that we're no longer on -dev :)

  • catch committed c388f66 on 9.0.x 
    Issue #3094007 by jibran, mikelutz, alexpott, Berdir: Update the 9.0.x...
catch’s picture

catch
he/him
Primary language English
commented
Issue summary: View changes
Status: Reviewed & tested by the community » Fixed
Issue tags: +9.0.0 release notes, +9.0.0 highlights

Committed c388f66 and pushed to 9.0.x. Thanks!

xjm’s picture

xjm
she/her
Primary language English
commented

Is the idea for adding this to the highlights that we want to promote the upgrade to Symfony 4 in the eventual frontpage post? (And Twig 2 and etc.)

krzysztof domański’s picture

krzysztof domański
Location Poland
commented
Issue tags: +Needs change record updates

I have attached this issue to CR Drupal 9 now requires Symfony 4.4.

krzysztof domański’s picture

krzysztof domański
Location Poland
commented
Related issues: +#3088754: Update to Drupal 9 to Symfony 4.4.0

Next #3088754: Update to Drupal 9 to Symfony 4.4.0.

krzysztof domański’s picture

krzysztof domański
Location Poland
commented
Issue tags: -9.0.0 release notes, -9.0.0 highlights, -Needs change record updates

I updated CR and I added tags to #3088754: Update to Drupal 9 to Symfony 4.4.0. They are no longer needed here.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.