Media Library's architecture and (few) extension points should be documented in media_library.api.php. That's about it.
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | interdiff-3088476-6-9.txt | 2.22 KB | phenaproxima |
| #9 | 3088476-9.patch | 4.03 KB | phenaproxima |
| #6 | interdiff-3088476-5-6.txt | 530 bytes | phenaproxima |
| #6 | 3088476-6.patch | 4.04 KB | phenaproxima |
| #5 | interdiff-3088476-3-5.txt | 3.42 KB | phenaproxima |
Comments
Comment #2
phenaproximaInitial patch.
Comment #3
phenaproximaA small rephrase in the add form stuff, added
@seelines for additional examples in core, and@defgroup.Comment #4
wim leersGreat start! I found a few nits and a few paragraphs that with some refinement will make it much easier to understand :)
🤓
or in text editors→or in text fields(Yes, the media library opener lives on a text editor, but the reusing of media happens in text fields.)
by special services, called "openers"→by "opener" servicesEssentially […] text editors.→
Openers enable different consumers of the Media Library to trigger a media library modal dialog in a way that makes sense for that particular consumer. Examples in Drupal core include entity reference fields and text editors."state" vs "status"
Should be "state" always.
Comment #5
phenaproximaTried to make these changes. How does this sound?
Comment #6
phenaproximaUgh, missed a word. I hate when I do that.
Comment #7
wim leersLooks much better, thanks!
Comment #8
alexpottI think this sentence is a bit confusing. I the the media library provides an alternate selection for entity reference fields AND provides another of select media to place in text fields. I think the re-use of the word
inis odd. You don'treuse and add media in entity reference fields- you're selecting the reference.This interaction is handled by form classes...I think this needs more detail. Feels a bit hand-wavy. I think this really relates to the next section. I think this sentence belongs there and needs to be re-wrriten a bit.Comment #9
phenaproximaHow's this? I tried to streamline it and explain it a bit more clearly.
Comment #10
starshapedThis documentation is clear, concise, and makes sense to me. Great job!
Comment #11
alexpottCommitted and pushed 2607278f2c to 9.0.x and 376a846edf to 8.9.x and 48229e83d2 to 8.8.x. Thanks!
Comment #15
xjmCrediting myself for this issue as well; it wasn't documented here, but I contributed to it in Slack. :P
Comment #16
xjmWe are in commit freeze though so this shouldn't have been backported to 8.8.x. Docs aren't going to break anything, but just FYI.