Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
This is spun off from #3071713: Make error messages for embedded media themeable.
By no means is this a major problem, but right now the Media module includes several test modules. Two of them, media_test_filter and media_test_ckeditor, have fairly significant overlap and it's not clear when to use which in tests.
Proposed resolution
Merge the two modules into one: media_test_embed.
Remaining tasks
Do it.
User interface changes
None.
API changes
Test modules are not APIs, so no.
Data model changes
None.
Release notes snippet
None.
Issue fork drupal-3085264
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
nginex CreditAttribution: nginex at Drupal Ukraine Community commentedTagging for Drupal Global Contribution Weekend
Comment #5
phenaproximaComment #9
phenaproximaThese changes look great and very straightforward. I have two very minor complaints/suggestions, but otherwise I think this looks ready. Nice work, @eric.napier!
Comment #10
eric.napier CreditAttribution: eric.napier at CivicActions commentedReady for another review, pushed initial change suggestions in MR.
Comment #11
phenaproximaHmm...it looks like a bunch of unrelated changes were also added?
Comment #12
eric.napier CreditAttribution: eric.napier at CivicActions commentedRebased to remove unwanted code in MR, ready for another review.
Comment #13
phenaproximaLooks great! If tests pass (and they should), this has my blessing. Onward!
Comment #15
webchickOk great! Verified that all of the lines removed from media_test_ckeditor are represented in media_test_embed and tests are indeed passing, sooo!
Committed and pushed to 9.2.x. Thanks!