Problem/Motivation

This is spun off from #3071713: Make error messages for embedded media themeable.

By no means is this a major problem, but right now the Media module includes several test modules. Two of them, media_test_filter and media_test_ckeditor, have fairly significant overlap and it's not clear when to use which in tests.

Proposed resolution

Merge the two modules into one: media_test_embed.

Remaining tasks

Do it.

User interface changes

None.

API changes

Test modules are not APIs, so no.

Data model changes

None.

Release notes snippet

None.

Issue fork drupal-3085264

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

phenaproxima created an issue. See original summary.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

nginex’s picture

nginex commented
Issue tags: +LutskGCW20

Tagging for Drupal Global Contribution Weekend

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Issue tags: +Media Initiative, +Triaged Media Initiative issue

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

eric.napier made their first commit to this issue’s fork.

eric.napier opened merge request !567

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Active » Needs work

These changes look great and very straightforward. I have two very minor complaints/suggestions, but otherwise I think this looks ready. Nice work, @eric.napier!

eric.napier’s picture

eric.napier commented
Status: Needs work » Needs review

Ready for another review, pushed initial change suggestions in MR.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs review » Needs work

Hmm...it looks like a bunch of unrelated changes were also added?

eric.napier’s picture

eric.napier commented
Status: Needs work » Needs review

Rebased to remove unwanted code in MR, ready for another review.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs review » Reviewed & tested by the community

Looks great! If tests pass (and they should), this has my blessing. Onward!

  • webchick committed 821ab2b on 9.2.x 
    Issue #3085264 by eric.napier, phenaproxima: Merge media_test_filter and...
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Ok great! Verified that all of the lines removed from media_test_ckeditor are represented in media_test_embed and tests are indeed passing, sooo!

Committed and pushed to 9.2.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.