drupalCreateNode() creates by default nodes owned by the user running the tests (uid = 1). This is confusing for the test writer and has lead to three bad consequences:

  1. The Path test case created its own version (PathTestCase::createNode),
  2. Several tests add an ugly ('uid' => $user->uid) to the drupalCreateNode() call,
  3. Several tests assigned their test users more rights that strictly necessary (edit all page content instead of edit own page content).
CommentFileSizeAuthor
#8 308296-drupalcreatenode-love-D7.patch11.3 KBdave reid
#6 308296-drupalcreatenode-love-D7.patch11.08 KBdave reid
#4 308296-drupalcreatenode-love.patch10.36 KBdave reid
#1 308296-drupalcreatenode-love.patch10.83 KBdamien tournoud

Comments

damien tournoud’s picture

damien tournoud commented
Status: Active » Needs review
StatusFileSize
new 308296-drupalcreatenode-love.patch10.83 KB

And the patch.

boombatower’s picture

boombatower commented

What about #212304: drupalCreateNode does not use the internal browser?

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Needs work

The last submitted patch failed testing.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs work » Needs review
StatusFileSize
new 308296-drupalcreatenode-love.patch10.36 KB

Re-rollin

Status: Needs review » Needs work

The last submitted patch failed testing.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs work » Needs review
StatusFileSize
new 308296-drupalcreatenode-love-D7.patch11.08 KB

Ok this one *should* pass all the tests now. I got too lazy to not run some local tests first and just relied on the testing bot. *slaps hand* Bad Dave...

Status: Needs review » Needs work

The last submitted patch failed testing.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs work » Needs review
StatusFileSize
new 308296-drupalcreatenode-love-D7.patch11.3 KB

Frak...that wasn't the latest version.

dries’s picture

dries commented
Status: Needs review » Fixed

Looks like a nice little clean-up. Committed to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.