Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.The current index tests only have one index type (_test_) and therefore don't have any guarantee that results are not crossing over. This addition sets the stage for more rigorous testing and does some basic smoke tests to see that changing the index type in the query indeed produces the right results.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | search.patch | 2.44 KB | robertdouglass |
| #5 | search.test.patch | 2.61 KB | robertdouglass |
| #3 | search.test.patch | 2.61 KB | robertdouglass |
| #2 | search.test.patch | 2.16 KB | boombatower |
| searchtest.patch | 2.29 KB | robertdouglass |
Comments
Comment #1
robertdouglass commentedComment #2
boombatower commentedLooks good, I would recommend making
_test_:in the documentation a bit more clear, but that is very small.Re-rolled against HEAD and removed a bit of white-spacing.
I'm not up on searching stuff, and minor issue so leaving as needs review.
Comment #3
robertdouglass commentedAdded comments for _test_, found a stray instance of foo. Foo tends to sneak in if you're not watching.
Comment #4
lilou commentedSmall typo :
+// In this test we test witl _test_ and _test2_ as the type.Comment #5
robertdouglass commentedComment #6
Anonymous (not verified) commentedThe last submitted patch failed testing.
Comment #7
robertdouglass commentedRerolled. Tests pass.
Comment #9
boombatower commenteddue to failure in HEAD: #74645: modify file_scan_directory to include a regex for the nomask.
Comment #10
catchLooks good to me. Still applies and passes.
Comment #11
webchickCommitted to HEAD. Thanks!