Problem/Motivation
In #2912387: Stop using wikimedia/composer-merge-plugin, an entry was added to the composer/installer rules to relocate the drupal/core project to the vendor directory:
"extra": {
"installer-paths": {
"vendor/drupal/core": ["type:drupal-core"]
}
}
This entry was necessary to make drupal/core work correctly as a Composer path repository. However, there are two minor undesirable effects:
- The entry itself in composer.json is confusing, and documenting .json files is not convenient.
- A symlink is created from vendor/drupal/core to the core directory, which may cause some confusion.
Note that this is only done when doing Drupal core development; users who are working from a template project (which will include all Drupal tarball downloads) will use the drupal/core subtree split.
Proposed resolution
Remove this entry from installer-paths once it is no longer necessary.
Remaining tasks
Composer 1.9 has been released; this version includes a fix to allow path repositories to be relocated on top of their source directory in #8254
We must require that this version of Composer be used to do Drupal core development in order to remove this installer path. We need to decide when to do this.
Follow on work
The continuation issue is #2701253: [meta] Make it possible to put modules into the vendor directory
User interface changes
None.
API changes
None.
Data model changes
None.
Comments
Comment #2
greg.1.anderson commentedComment #3
MixologicComment #4
greg.1.anderson commentedThe Composer project has fixed this issue in 872604a. It will ship as part of Composer 1.9.
Once Composer 1.9 is available, and once we decide to require Composer 1.9 as a requirement for doing core development on Drupal 8.8.x, we can remove the entry for
type:drupal-corein installer-paths.Alternately, if we wanted to require a dev version of Composer for doing core development on Drupal 8.8.x, we could remove this entry now. It is my presumption, though, that the workaround is preferable to making everyone install dev software.
Comment #5
greg.1.anderson commentedUpdate remaining tasks / follow-on work.
Comment #6
greg.1.anderson commentedComment #7
MixologicSince composer 1.9 is out now, and the patch in https://www.drupal.org/project/drupal/issues/2912387 was rolled back, this is no longer relevant, as the current patch there doesnt require this.