Problem/Motivation

The demo_umami_tour module is a separate, profile-specific module inside of the demo_umami profile even though it's sole purpose is to provide configuration, which can be done by the profile itself.

In #2989541-5: Add a welcome tour to Umami @kjay says:

Whilst we're developing the feature, @smaz believes it will be easier to keep the tour as a module since you can enable/disable the module with Drush each time the tips are edited or new ones added.

But the adding of the new module was never rectified in the further development of that patch and now the module lives in Drupal core.

This causes unnecessary maintenance overhead.

Concretely, in #3059545: Improve \Drupal\KernelTests\Config\DefaultConfigTest to install all optional configuration it was found that because the tour configuration is in a separate module it is not covered by DemoUmamiProfileTest::testConfig().

Proposed resolution

Remove the module and move the configuration it provides into the profile itself. Nothing will change funtionally, the Umami tour will still be there.

Comments

tstoeckler created an issue. See original summary.

tstoeckler’s picture

Status: Active » Needs review

So, this indeed fails DemoUmamiProfileTest::testConfig(). Will see if there are any other failures first before uploading a patch with the fix.

tstoeckler’s picture

StatusFileSize
new1.59 KB

Ahem.

Status: Needs review » Needs work

The last submitted patch, 3: 3060602-2.patch, failed testing. View results

tstoeckler’s picture

Status: Needs work » Needs review
StatusFileSize
new484 bytes
new1.65 KB

Awesome, so this should be green, then.

I guess technically because of the incorrect dependency this is a bug fix, but leaving as task for now, as I think the removal of the module is the larger issue, even if it is the best way to actually provide test coverage for the bug fix.

Not sure what the policy regarding Umami is in terms of backporting this, though. Leaving at 8.8.x for now.

alexpott’s picture

+1 to less modules in Umami - nice and fix.

lendude’s picture

Status: Needs review » Reviewed & tested by the community

No nits to pick, nice find and fix!

catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed ff30107 and pushed to 8.8.x. Thanks!

  • catch committed ff30107 on 8.8.x
    Issue #3060602 by tstoeckler: demo_umami_tour should not be a separate...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.