Problem/Motivation

Drupal's dialog.ajax.es6.js copies form buttons, but leaves the original button with an overridden style in the modal content, see Drupal.behaviors.dialog.prepareDialogButtons()

Claro shows a blue pixel artefacts because of this css:

.button {
  border: 1px solid transparent !important;
}

Proposed resolution

Remove the blue pixel artefact in modal content.

Remaining tasks

  1. Write a patch
  2. Review
  3. Commit

User interface changes

Modal content no longer shows a blue pixel artefact.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#11 Bildschirmfoto 2019-10-29 um 13.08.55.png356.17 KBjepster_
#11 Bildschirmfoto 2019-10-29 um 13.09.39.png610.25 KBjepster_
button-pixel-artifact.gif830.84 KBidebr

Comments

idebr created an issue. See original summary.

idebr’s picture

idebr commented
Related issues: +#3053690: dialog.es6.js uses inline CSS to apply visually-hidden

This issue can also be solved by applying the 'visually-hidden' class to the visually hide the buttons, see #3053690: dialog.es6.js uses inline CSS to apply visually-hidden

junaidmasoodi’s picture

junaidmasoodi commented
Assigned: Unassigned » junaidmasoodi
junaidmasoodi’s picture

junaidmasoodi commented

I am working on this over this weekend

huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented
Project: Claro » Drupal core
Version: 8.x-1.x-dev » 8.9.x-dev
Component: Code » Claro theme
fhaeberle’s picture

fhaeberle
he/him
Location 🇩🇪 Stuttgart
commented
Assigned: junaidmasoodi » Unassigned
Issue tags: +Novice, +DrupalCon Amsterdam 2019
chrisdarke’s picture

chrisdarke commented
Issue tags: -Novice, -DrupalCon Amsterdam 2019 +Amsterdam2019

Updating tags for DrupalCon Amsterdam 2019

fhaeberle’s picture

fhaeberle
he/him
Location 🇩🇪 Stuttgart
commented
Issue tags: -Amsterdam2019 +Novice, +DrupalCon Amsterdam 2019

Hello and thanks for the update. We're using the DrupalCon Amsterdam 2019 tag for our contribution. Setting it back.

jepster_’s picture

jepster_
Location 🇩🇪Düsseldorf
commented
Assigned: Unassigned » jepster_
Status: Active » Needs work
chrisdarke’s picture

chrisdarke commented
Issue tags: -Novice, -DrupalCon Amsterdam 2019 +Amsterdam2019

Hi @fhaeberle. the drupal #mentoring team are maintaining a curated set of novice issues for first time contribution sprints on Thursday, and we are tagging with Amsterdam2019, not the DrupalCon Amsterdam 2019 tag, also removing novice tag till thursday. Please give us a shout on the #mentoring channel on Slack if there are any issues with this, thanks!

jepster_’s picture

jepster_
Location 🇩🇪Düsseldorf
commented
StatusFileSize
new Bildschirmfoto 2019-10-29 um 13.09.39.png610.25 KB
new Bildschirmfoto 2019-10-29 um 13.08.55.png356.17 KB

Cannot be reproduced with the current 8.9.x Git branch.

What have I did?

  1. Enabled Claro
  2. Enabled media library
  3. Added a media reference field
  4. Selected the media library in the form display
  5. Tried to reproduce the artifact in the media library modal
  6. Could not see any artifact

See attached screenshots.

If you are able to reproduce the issue, please provide details about the form display settings, so it is exactly clear which form widget you have been using.

jepster_’s picture

jepster_
Location 🇩🇪Düsseldorf
commented
Assigned: jepster_ » Unassigned
Status: Needs work » Needs review
idebr’s picture

idebr commented
Status: Needs review » Closed (duplicate)
Related issues: +#3037781: Accessibility problem with invisible buttons in AJAX dialogs

This was fixed in #3037781: Accessibility problem with invisible buttons in AJAX dialogs