Problem/Motivation
CommentFieldNameTest makes no HTTP requests but is a functional test
Proposed resolution
Convert CommentFieldNameTest into a Kernel test
Remaining tasks
None.
User interface changes
None.
API changes
None.
Data model changes
None.
Release notes snippet
N/A
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 3049604-2.patch | 5.69 KB | claudiu.cristea |
Comments
Comment #2
claudiu.cristeaThis patch decreases the locally test run from 14.5 to 2.4 seconds.
Comment #3
manuel garcia commentedAwesome!
Are we loosing coverage here for view access on render?
Comment #4
claudiu.cristeaThat view has nothing to do with the user context. Neither has contextual filters depending on the logged in user
Comment #5
manuel garcia commentedAh ok then, thats the only thing I could think of, and the rest looks great- so RTBCing :)
Comment #6
alexpott@claudiu.cristea the access thing here feels tricky. If you comment out
user_role_grant_permissions(RoleInterface::ANONYMOUS_ID, ['access comments']);in the original test it still passes so you're right that access is not being tested but should it be being tested? The only thing in CommentViewsData I can find is$data['comment_field_data']['table']['base']['access query tag'] = 'comment_access';and that's not being tested here (or anywhere else for that matter).Committed 3a1d204 and pushed to 8.8.x. Thanks!
Will backport to 8.7.x later.
Comment #8
alexpott