Problem/Motivation

ArgumentValidatorTermTest makes no HTTP requests but is a functional test

Proposed resolution

Convert ArgumentValidatorTermTest into a Kernel test

Remaining tasks

None.

User interface changes

None.

API changes

None.

Data model changes

None.

Release notes snippet

N/A

CommentFileSizeAuthor
#2 3042877-2.patch4.46 KBclaudiu.cristea

Comments

claudiu.cristea created an issue. See original summary.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Status: Active » Needs review
StatusFileSize
new 3042877-2.patch4.46 KB

This patch decreases the locally test run from 10.2 to 4.1 seconds.

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
Status: Needs review » Reviewed & tested by the community

Looked at before and after, I can see no loss of coverage, great!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: 8.8.x-dev » 8.7.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 674251e807 to 8.8.x and 4ae5c313eb to 8.7.x. Thanks!

As a test only change backported to 8.7.x - I discussed backporting test-only changes with @catch (as a release manager).

  • alexpott committed 674251e on 8.8.x 
    Issue #3042877 by claudiu.cristea, Lendude: Convert...

  • alexpott committed 4ae5c31 on 8.7.x 
    Issue #3042877 by claudiu.cristea, Lendude: Convert...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.