Don't use drupal_static in AutoIncrementingTestItem

+++ b/core/modules/system/tests/modules/entity_test/src/Plugin/Field/FieldType/AutoIncrementingTestItem.php
@@ -17,6 +17,13 @@
+  protected static $cache = 0;

as it used in private method maybe better to make var private so it will not be serialized?

Everytime I read stackoverflow concerning static properties -- andypost's serialisation comment comes up.

So I think the change makes sense to me

@claudiu.cristea - thanks for all the effort you have made recently into removing drupal_static(() calls from core.
It is really good to see.

claudiu.cristea++

Nice

+++ b/core/modules/system/tests/modules/entity_test/src/Plugin/Field/FieldType/AutoIncrementingTestItem.php
@@ -17,6 +17,13 @@
 
+  /**
+   * Memory cache.
+   *
+   * @var int
+   */
+  private static $cache = 0;
+
   /**
    * {@inheritdoc}
    */
@@ -32,8 +39,7 @@ public function preSave() {

@@ -32,8 +39,7 @@ public function preSave() {
    *   The incremented field value.
    */
   private static function getIncrementedFieldValue() {
-    $current_value = &drupal_static(__METHOD__, 0);
-    return ++$current_value;
+    return ++static::$cache;
   }
 

Since the variable is only used in this one method, could it just be declared in the method itself instead of as a static class property?

nice

Committed 59f1d6c and pushed to 8.8.x. Thanks!