Problem/Motivation

In #3024341: Improve deprecation listing with filtering @jhodgdon found two instances of deprecation messages where the message says the functionality should have already been removed. That is very likely not the case. We should update these messages to say the removal will be before Drupal 9.0.0. Format now exactly follows https://www.drupal.org/core/deprecation.

Proposed resolution

Fix the messages.

Remaining tasks

Review. Commit.

User interface changes

None.

API changes

None.

Data model changes

None.

Release notes snippet

N/A.

CommentFileSizeAuthor
#2 3033317.patch1.74 KBgábor hojtsy

Comments

Gábor Hojtsy created an issue. See original summary.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Title: Fix deprecated messages saying we should have removed something we'll only remove right before Drupal 9.0.0 » AccountProxy initialAccountId and ViewKernelTestBase will only be removed in Drupal 9.0.0, fix deprecation messages
StatusFileSize
new 3033317.patch1.74 KB
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Reviewed & tested by the community 
+++ b/core/modules/views/src/Tests/ViewKernelTestBase.php
@@ -2,7 +2,7 @@
 namespace Drupal\views\Tests;
 
-@trigger_error(__NAMESPACE__ . '\ViewKernelTestBase is deprecated in Drupal 8.0.x, will be removed in Drupal 8.2.x. Use \Drupal\Tests\views\Kernel\ViewsKernelTestBase instead.', E_USER_DEPRECATED);
+@trigger_error(__NAMESPACE__ . '\ViewKernelTestBase is deprecated in Drupal 8.0.0 and will be removed before Drupal 9.0.0. Use \Drupal\Tests\views\Kernel\ViewsKernelTestBase instead.', E_USER_DEPRECATED);

This is based on the original plan to remove the old kernel test base class already in 8.2 or 8.3.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

I also opened #3033332: [META] Fix language and consistency of deprecation messages and annotations as while working on this one I found a lot of inconsistencies, like "removed in before Drupal 9" and "as of 8.5.x" (later of which does not say Drupal and should have been 8.5.0), etc. That turned out to be a huge beast. Nonetheless it would be important to get done ASAP as we start to promote and surface these messages.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

No harm in changing this even if we're gonna change them again when we finalise the standard.

Committed 4a1519b and pushed to 8.7.x. Thanks!

  • alexpott committed 4a1519b on 8.7.x 
    Issue #3033317 by Gábor Hojtsy: AccountProxy initialAccountId and...
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Conflicted on 8.6.x so not worrying about that.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.