Problem/Motivation

TODO

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comments

plach created an issue. See original summary.

plach’s picture

Status: Active » Postponed
berdir’s picture

I find it interesting that you propose this, since you were kind of against #2978048: Unpublished translations should fallback to the original language, but removing the separate context key will have exactly the same result :)

plach’s picture

I was against unnecessarily changing that behavior, although I admittedly was not happy about it, now we have a good reason to :)

plach’s picture

Title: [PP-1] Deprecate the "entity_upcast" operation specified in EntityConverter » Deprecate the "entity_upcast" operation specified in EntityConverter
Status: Postponed » Active

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

geek-merlin’s picture

berdir’s picture

Status: Postponed » Active

Same as the other issue you commented on, I don't understand how a core issue should be postponed on/duplicated by a contrib module/issue?

geek-merlin’s picture

As noted in #2978048: Unpublished translations should fallback to the original language:

Ups, facepalm, i meant to paste #2951294: Sort out and fix language fallback inconsistencies and would be happy if you comment there on the updated IS.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

dmitriy.trt’s picture

Just want to leave some feedback about possible deprecation of the "entity_upcast" operation. It would make things more consistent for entity view, because of content_translation_language_fallback_candidates_entity_view_alter() that is not applied now to the upcast operation. However, it may cause other troubles, because not all routes display an entity. Some are for editing, deleting an entity or a translation/revision overview and the language fallback logic that is applicable to entity view may not be applicable to these cases. For example, user definitely don't want to delete a fallback translation instead of the actual one. It would be useful to somehow distinguish different types of routes for the language fallback mechanism, e.g. through passing a different operation depending on the type of route.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

andypost’s picture

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

berdir’s picture

#15: That is a valid concern. What's interesting is that \Drupal\Core\Entity\EntityRepository::getActiveMultiple() already in HEAD does not use the entity_upcast operation but the default, so the default fallbacks are already applied, so that is pretty much already an issue but I think it doesn't happen that much in practice. You won't see a delete link if a translation doesn't exist and if you can delete a translation you can also view an unpublished translation and a fallback doesn't apply.

andypost’s picture

Issue tags: +blocker
berdir’s picture

Note1: I'm currently doing a test implementation of this in #3158130: Many calls to ContextRepository::getAvailableContexts() due to entity upcasting to get rid of that whole context stuff of that API, which I really don't understand why it was added like that and causes major performance issues.

Note2: There is zero issue summary here but this issue was created based on comment #2942907-98: Entity system does not provide an API for retrieving an entity variant that is safe for editing by plach:

> 6: Actually we can do even better, we can get rid of that entirely in [this issue], since apparently no one is using it ;)

According to the comments in #2978048: Unpublished translations should fallback to the original language, this is not correct, and people are in fact relying on it. core doesn't use it, which is IMHO a bug on its own (or it's a bug that entity_upcast ever existed), which is what the referenced issue is about, but now that it does, things are more complicated than that. A classic https://xkcd.com/1172/ ;)

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.