Problem/Motivation

Came up as a test fail as part of #2976394: Allow Symfony 4.4 to be installed in Drupal 8 but it is not technically a Symfony 4 fail, since the implemented methods were already internal in Symfony 3.4. It looks as though this interface was not meant to be implemented as it explicitly says some of its methods are not to be considered stable.

Proposed resolution

Ultimately looks like we need to get off of this interface. #2976394: Allow Symfony 4.4 to be installed in Drupal 8 just added it to the deprecation listener to silence the message.

Remaining tasks

Fix on the Drupal 9 branch.

User interface changes

None.

API changes

None.

Data model changes

None.

Release notes snippet

N/A

CommentFileSizeAuthor
#6 3030474-6-with-2976394-134.patch163.46 KBgábor hojtsy
#6 3030474-6.patch2.03 KBgábor hojtsy
#3 3030474-2-with-2976394-134.patch163.47 KBgábor hojtsy
#2 3030474-2.patch2.04 KBgábor hojtsy

Comments

Gábor Hojtsy created an issue. See original summary.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Active » Needs review
StatusFileSize
new 3030474-2.patch2.04 KB
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
StatusFileSize
new 3030474-2-with-2976394-134.patch163.47 KB

Rolled in with #2976394-134: Allow Symfony 4.4 to be installed in Drupal 8.

Status: Needs review » Needs work

The last submitted patch, 3: 3030474-2-with-2976394-134.patch, failed testing. View results

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

Hm that did not make the notices go away :/

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs work » Needs review
Issue tags: +Symfony 4
StatusFileSize
new 3030474-6.patch2.03 KB
new 3030474-6-with-2976394-134.patch163.46 KB

#3031577: \Drupal\Tests\Listeners\DeprecationListenerTrait::getSkippedDeprecations() does not work in unit tests most probably solved our fails here. I rerolled because the patches did not apply anymore. The Symfony 4 combined patch segment is still up to date.

Status: Needs review » Needs work

The last submitted patch, 6: 3030474-6-with-2976394-134.patch, failed testing. View results

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs work » Postponed

#3031577: \Drupal\Tests\Listeners\DeprecationListenerTrait::getSkippedDeprecations() does not work in unit tests got rolled back in the meantime so its fail may or may not be indicative of the patch not being sufficient. Postponing on that again.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Parent issue: » #2976394: Allow Symfony 4.4 to be installed in Drupal 8

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Postponed » Closed (duplicate)

This has been part of #2976394: Allow Symfony 4.4 to be installed in Drupal 8 for a while. Can close this as duplicate.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Version: 8.8.x-dev » 9.x-dev
Issue summary: View changes
Status: Closed (duplicate) » Postponed

Well, hm, that refers to this issue to actually resolve it since the patch just skips the deprecation there. So we should still keep it open postponed on Drupal 9 branch.

Version: 9.x-dev » 9.0.x-dev

The 9.0.x branch will open for development soon, and the placeholder 9.x branch should no longer be used. Only issues that require a new major version should be filed against 9.0.x (for example, removing deprecated code or updating dependency major versions). New developments and disruptive changes that are allowed in a minor version should be filed against 8.9.x, and significant new features will be moved to 9.1.x at committer discretion. For more information see the Allowed changes during the Drupal 8 and 9 release cycles and the Drupal 9.0.0 release plan.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Postponed » Closed (duplicate)

The deprecation listener was updated with a similar fix in #3088369: Update Drupal 9 to Symfony 4.4-dev.