Problem/Motivation

With Symfony 4 there are lots of deprecation notices like this:

 1x: The default value of the "$secure" and "$samesite" arguments of "Symfony\Component\HttpFoundation\Cookie::__construct"'s constructor will respectively change from "false" to "null" and from "null" to "lax" in Symfony 5.0, you should define their values explicitly or use "Cookie::create()" instead.

One or two of these are from our own code, but most are from \Behat\Mink\Driver\BrowserKitDriver so will require an upstream patch and new release to resolve (if there isn't one already we can update to). While this is a Symfony 4 deprecation, the only change required is to specify the constructor arguments explicitly.

In the meantime we could also add the deprecation notice to our expected deprecations.

Proposed resolution

Patch core code that we can control.

Locate or post an upstream issue/release for Mink to update to the new API.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3027910.patch1.81 KBcatch
#2 3027910-combined.patch159.41 KBcatch

Comments

catch created an issue. See original summary.

catch’s picture

Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new159.41 KB
new1.81 KB
catch’s picture