Problem/Motivation

The . \Drupal\system\SystemManager::getAdminBlock sets 'options' for the links. It seems like it isn't being used anywhere, and it is untested.

Proposed resolution

Remove 'options' from the links array.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#6 3023638-6.patch633 bytesranjith_kumar_k_u
#2 remove-options.patch637 byteslauriii

Comments

lauriii created an issue. See original summary.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Active » Needs review
StatusFileSize
new remove-options.patch637 bytes

Simple patch with just removal of the array item to ensure there's not test failures.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

ranjith_kumar_k_u’s picture

ranjith_kumar_k_u commented
StatusFileSize
new 3023638-6.patch633 bytes

Re-rolled for 9.1.x-dev

tanubansal’s picture

tanubansal commented

Tested #6, changes are visible on 9.1
RTBC + 1

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Reviewed & tested by the community

I traced through the related preprocess functions and templates and don't see where this is used.

I suppose there is an outside chance that custom code may be relying on this being present? However as the documentation for the preprocess and templates are woefully out of date it is hard to know what downstream might be doing here.

Marking RTBC anyway, as this isn't used as-is in core. Also opened #3174832: admin-block-content template variable documentation is incorrect to fix the documentation.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

xjm’s picture

xjm
she/her
Primary language English
commented
Issue tags: +Needs release manager review

This seems like a BC break; aren't these alterable by contrib?

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs review

Yes it looks to me like information we're making available to contrib/custom themes, whether or not core uses it - like a lot of stuff in preprocess.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

Maybe we should close this and put #3174832: admin-block-content template variable documentation is incorrect back to NW to actually document this?

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Closed (won't fix)

This is at least documented now, so I don't think we should remove this if there is a chance others are using it.