Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Issue #2966523: MySQL 8 Support added support for MySQL 8, and one of the changes was that it escaped all MySQL reserved keywords.
Whenever the quoteIdentifier method is called, it performs an in_array() call.
in_array() calls are O(n) because it has to iterate through all the elements in the reserved keywords array. The reserved keywords array has 263 elements as of now. Because this function is called for each alias, field, and table the number of calls to this function can add up easily.
I would like to suggest that we convert this to an isset() call instead. We can flip the reserved keywords array to make the reserved keywords as array keys, so we can perform a (close to) an O(1) isset() lookup.
Here is a quick benchmark: https://3v4l.org/ctKEL
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 3020839-2-mysql-8-keyword-escape-performance-improvements.patch | 10.7 KB | ayesh |
Comments
Comment #2
ayesh commentedAttaching the suggested patch.
I also introduced the static keyword because the reserved values do not change between connections.
Comment #3
ayesh commentedComment #4
ayesh commentedComment #6
andypostComment #8
daffie commented#2986452: Database reserved keywords need to be quoted as per the ANSI standard has landed. Making this issue moot.
Edit: Changed mute to moot. Sorry I am not a native English speaker.
Thank you @idebr.
Comment #9
idebr commentedmoot*
(sorry)