Problem/Motivation

The constructor for this event has got stricter, we were passing 'foo' so can just pass something valid instead.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 filter_response_event.patch760 bytescatch

Comments

catch created an issue. See original summary.

catch’s picture

catch
he/him
Primary language English
commented
StatusFileSize
new filter_response_event.patch760 bytes
catch’s picture

catch
he/him
Primary language English
commented
Status: Active » Needs review
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

I wrote that test at some point. I don't know why I chose 'foo'. There's no good reason to do so.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed 96ef995291 to 8.7.x and 017a22fa78 to 8.6.x. Thanks!

Backported to 8.6.x to keep tests aligned.

  • alexpott committed 96ef995 on 8.7.x 
    Issue #3020579 by catch: TypeError: Argument 3 passed to Symfony\...

  • alexpott committed 017a22f on 8.6.x 
    Issue #3020579 by catch: TypeError: Argument 3 passed to Symfony\...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

xjm’s picture

xjm
she/her
Primary language English
commented
Issue tags: +Symfony 4