Problem/Motivation

QuickStartTest passes the command as a string to Process, but from Symfony 4.2 it only accepts an array.

Proposed resolution

Remaining tasks

Symfony 3.4 accepts an array too, so we can just do that.

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
QuickStartTest-Process.patch4.43 KBcatch

Comments

catch created an issue. See original summary.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Symfony 4

This was … trivial. 😀

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

The test commands are still firing...

Committed and pushed b4297ade9e to 8.7.x and dade5a356a to 8.6.x. Thanks!

Backported to 8.6.x to keep tests aligned.

diff --git a/core/tests/Drupal/Tests/Core/Command/QuickStartTest.php b/core/tests/Drupal/Tests/Core/Command/QuickStartTest.php
index 6e45f0b1fe..5622aa2375 100644
--- a/core/tests/Drupal/Tests/Core/Command/QuickStartTest.php
+++ b/core/tests/Drupal/Tests/Core/Command/QuickStartTest.php
@@ -92,7 +92,7 @@ public function testQuickStartCommand() {
       'quick-start',
       'standard',
       "--site-name='Test site {$this->testDb->getDatabasePrefix()}'",
-      '--suppress-login'
+      '--suppress-login',
     ];
     $process = new Process($install_command, NULL, ['DRUPAL_DEV_SITE_PATH' => $this->testDb->getTestSitePath()]);
     $process->inheritEnvironmentVariables();

Fixed coding standard on commit.

  • alexpott committed b4297ad on 8.7.x 
    Issue #3020550 by catch: Passing commands as a string to Process is...

  • alexpott committed dade5a3 on 8.6.x 
    Issue #3020550 by catch: Passing commands as a string to Process is...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.