Problem/Motivation

\Drupal\Core\Extension\Dependency objects are serialised as part of extension objects. If they have a constraint object then it'll be serialised too but it doesn't need it because we can create them from the constraintString. Constraints aren't needed often so let's not serialise them too.

Proposed resolution

Don't serialise constraint objects. Smaller cache object for the win.

Remaining tasks

User interface changes

None

API changes

None

Data model changes

None

Release notes snippet

None

CommentFileSizeAuthor
#2 3020165-2.patch1.83 KBalexpott

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review
StatusFileSize
new 3020165-2.patch1.83 KB

Here's a patch split off from #2701829: Extension objects should not implement \Serializable

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Reviewed & tested by the community

1:1 from the previous larger patch, was already RTBC there and tested. Yay for smaller cache records ;)

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed e5b7063 and pushed to 8.7.x. Thanks!

  • catch committed e5b7063 on 8.7.x 
    Issue #3020165 by alexpott: Dependency objects can be optimised for...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.