Closed (outdated)
Project:
Drupal core
Version:
7.x-dev
Component:
filter.module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
10 Oct 2018 at 12:32 UTC
Updated:
27 Apr 2020 at 18:31 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
pingwin4egHere's the patch.
Comment #4
pingwin4egHmm, let's try the same patch created using diff.
Comment #5
pingwin4egComment #6
tr commentedWhen you said
you didn't include a link to the issue containing the change that needs backporting.
I was able to trace that change to #900956: Update autop filter to include missing block level tags, committed in 2013:
The problem with your patch is that you are making out-of-scope coding standards changes in your backport, in addition to changing just the two lines that were modified in #900956: Update autop filter to include missing block level tags. Plus, you coding standards changes are not proper (no upper case, no line terminator on inline comments).
As a minimum, this patch needs a re-roll to remove those out-of-scope changes. That will make the patch much easier to review properly.
Comment #7
tr commentedComment #8
pingwin4egOh, those coding standards changes are definitely not mine)))
As far as I remember, the patch was a pure diff of the
_filter_autop()between D7 and D8 at the time. And this issue title and the proposed resolution are evidence of that.That's why I didn't include links to any specific issues. There are few of them. HTML5 block tags were just one example of what was missing in D7.
And the mess with comments is still there in the HEAD.