Viewing pagers beyond the second page.
Viewing pagers with different number of results per page.

CommentFileSizeAuthor
#2 pager.test.patch5.32 KBjhedstrom

Comments

lilou’s picture

See also this pager bug : #293664: Pager error on search module

jhedstrom’s picture

Assigned: Unassigned » jhedstrom
Status: Active » Needs review
StatusFileSize
new5.32 KB

The attached patch adds tests for the pager queries, and also for cycling through node?page=x pages (e.g., the default front page pager).

Anonymous’s picture

Status: Needs review » Needs work

The last submitted patch failed testing.

jhedstrom’s picture

Status: Needs work » Needs review

Odd, the patch still passes for me...setting back to needs review.

Anonymous’s picture

Status: Needs review » Needs work

The last submitted patch failed testing.

jhedstrom’s picture

Component: tests » base system
Status: Needs work » Reviewed & tested by the community

Tests still pass...writing off to a bad day for the testing bot.

jhedstrom’s picture

Status: Reviewed & tested by the community » Needs review

oops...wrong status on the last post.

Status: Needs review » Needs work

The last submitted patch failed testing.

jhedstrom’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch failed testing.

mcjim’s picture

Status: Needs work » Needs review

Patch passes testing locally, marking as patch (code needs review).

Status: Needs review » Needs work

The last submitted patch failed testing.

mr.baileys’s picture

Tests do not pass on my local installation.

Looks like this assertion fails every time on my end:

+      else {
+        $link = t('<li class="pager-item"><a href="!url" title="Go to page @page" class="active">@page</a></li>', array('!url' => url('node', array('query' => 'page=' . $i)), '@page' => $i + 1));
+        $this->assertRaw($link, t('Found pager link to page @page', array('@page' => $i + 1)));
+      }
mr.baileys’s picture

First line is what the assertion looks for, the second line is what my pages actually contain:

<li class="pager-item"><a href="/index.php?q=node&page=1" title="Go to page 2" class="active">2</a></li>
<li class="pager-item"><a href="/index.php?q=node&amp;page=1" title="Go to page 2" class="active">2</a></li>
catch’s picture

Category: bug » task
Priority: Critical » Normal

Moving this out of the critical bugs queue - see #607038: Meta issue: fix gaps in code coverage.

jhedstrom’s picture

Assigned: jhedstrom » Unassigned
Issue summary: View changes
Status: Needs work » Closed (outdated)