A number of tests and internal functions use xpath to make assertions. This is a very powerful feature, but is not documented or exposed in any way.

This patch adds an xpath method to DrupalWebTestCase so that it can be both documented, used consistently, and enclosed in the proper $this->parse() condition.

The patch also reactors existing tests and internal code that uses xpath. Changing $this->elements->xpath(...) becomes $this->xpath(...).

I have not tested this patch and will get back to it, but I have to leave at the moment so I figured I would post what I have.

CommentFileSizeAuthor
#5 simpletest_xpath.patch6.35 KBboombatower
#2 simpletest_xpath.patch6.35 KBboombatower
simpletest_xpath.patch6.34 KBboombatower

Comments

boombatower’s picture

boombatower commented
Status: Needs review » Needs work

Making some changes.

boombatower’s picture

boombatower commented
Status: Needs work » Needs review
StatusFileSize
new simpletest_xpath.patch6.35 KB

Just needed $this->elements->xpath() instead of $this->xpath() (recursion heh).

boombatower’s picture

boombatower commented
Priority: Normal » Critical

This patch is required for: #297894: Add assertLink and assertNoLink to SimpleTest
which is required for: #296693: Restrict access to empty top level administration pages
which is required for: #263616: Move SimpleTest out of "Site building"

So I'll mark it as critical.

boombatower’s picture

boombatower commented
Status: Needs review » Needs work

Ran tests on changed/effected code and they all pass except two with exception. If someone wants to run on all tests that would be great.

SimpleTest functionality: 43 passes, 0 fails, 2 exceptions
Drupal HTTP request: 4 passes, 0 fails, 2 exceptions

boombatower’s picture

boombatower commented
Status: Needs work » Needs review
StatusFileSize
new simpletest_xpath.patch6.35 KB

This should fix the exception mentioned. Still need whole suite to be run.

boombatower’s picture

boombatower commented

Ran entire test suite with all passes.

moshe weitzman’s picture

moshe weitzman commented

Code looks good to me. Since the test suite still runs to 100% perfecton, this is RTBC.

moshe weitzman’s picture

moshe weitzman commented
Status: Needs review » Reviewed & tested by the community
dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.