Problem/Motivation

We should remove usages of \Drupal\taxonomy\Tests\TaxonomyTranslationTestTrait with \Drupal\Tests\taxonomy\Functional\TaxonomyTranslationTestTrait.

Proposed resolution

Replace all the usages of \Drupal\taxonomy\Tests\TaxonomyTranslationTestTrait with \Drupal\Tests\taxonomy\Functional\TaxonomyTranslationTestTrait.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#8 2969805_8.patch500 bytesmile23
#2 2969805-2.patch10.83 KBmarcel66

Comments

marcel66 created an issue. See original summary.

marcel66’s picture

marcel66 commented
Status: Active » Needs review
StatusFileSize
new 2969805-2.patch10.83 KB

Replaced old test with functional one.

Status: Needs review » Needs work

The last submitted patch, 2: 2969805-2.patch, failed testing. View results

amateescu’s picture

amateescu commented
Issue tags: -DCTransylvania2018

Let's use a single tag for our sprint :)

marcel66’s picture

marcel66 commented

I have reviewed https://www.drupal.org/files/issues/2018-04-17/2887134-15.patch and it also replaced the TermTranslationTest with a functional one and also some other taxonomy test.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

marcel66’s picture

marcel66 commented
Assigned: marcel66 » Unassigned
mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
StatusFileSize
new 2969805_8.patch500 bytes

Patch in #2 does not apply.

We don't see a deprecation error because the only usage is in Drupal\taxonomy\Tests\TermTranslationTest, which is a simpletest. That's why we don't have this deprecation message in DeprecationListenerTrait.

Drupal\taxonomy\Tests\TermTranslationTest will be converted to BTB in #2887134: Convert web tests to browser tests for taxonomy module Part -2

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
Status: Needs work » Needs review
mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
Status: Needs review » Closed (outdated)

#2887134: Convert web tests to browser tests for taxonomy module Part -2 fixes the problem in #8 by moving Drupal\Tests\taxonomy\Functional\TermTranslationTest so it uses Drupal\Tests\taxonomy\Functional\TaxonomyTranslationTestTrait.

Also verifying that Drupal\Tests\Listeners\DeprecationListenerTrait::getSkippedDeprecations() does not skip the deprecation error message: https://cgit.drupalcode.org/drupal/tree/core/tests/Drupal/Tests/Listener...

Thanks, folks.