The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.The documentation for $op = 'configure' is incorrect: it says the hook should return a string, although it really should return a form array.
The code example given uses "else if" although the coding standards specify use of "elseif" instead.
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | block5.patch | 1.56 KB | fgm |
| #5 | block5.patch | 2.01 KB | fgm |
| #3 | core5.patch | 2.53 KB | fgm |
| core.php_.patch | 2.59 KB | fgm |
Comments
Comment #1
betz commentedComment #3
fgmNo, the error is in the 5.x doc, not 7.x, as indicated by the $Id$ strings in the patch.
Strange thing is it applies cleanly when I apply it manually, but not on testing.d.o. ?
Comment #5
fgmYet one more attempt.
Comment #7
webchickYeah, ignore testing bot. He's stupid and doesn't know about docs/developer.
That said, block5.patch is a very strange looking diff and seems to have nothing to do with blocks.
core5.patch looks okay, except I think you are missing a couple "If"s before $op is 'list' and $op is 'configure'.
Feel free to commit this when you fix that.
Comment #8
webchickAlso double-check to make sure that DRUPAL-6 and HEAD don't need the same fix.
Comment #9
fgmOne last (?) attempt.
This specific problem has been fixed in the D6 and D7 docs but they both have a less important problem (list indenting).
However, the source seems to be correct, which makes it look like a bug in the way api.module formats 3-level deep lists when the 2nd-level list contains items after a 3rd-level list. There is no other occurrence of this situation in core.php.
Comment #11
fgmCommitted. Note sure about the commit message format, though.
Comment #12
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.