Problem/Motivation

XmlEncoder currently extends SerializerAwareEncoder, which is deprecated since Symfony 3.2 and will be removed in version 4.0. It is suggested that SerializerAwareTrait be used instead.

Proposed resolution

Alter XmlEncoder so it does not extend SerializerAwareEncoder, but implements SerializerAwareInterface directly and uses SerializerAwareTrait;

Remaining tasks

None.

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#2 2958293-2.patch1.08 KBrlhawk

Comments

rlhawk created an issue. See original summary.

rlhawk’s picture

rlhawk
Primary language English
Location Seattle, Washington, United States
commented
Status: Active » Needs review
StatusFileSize
new 2958293-2.patch1.08 KB

Here's a patch that implements this change.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue tags: +Symfony2

Perfect! Thank you for helping us stay on top of things! I hope to see you around more, it's extremely rare that one can RTBC the first iteration of a patch! :D (Be proud!)

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Reviewed & tested by the community
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Priority: Normal » Minor
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed c3e5648 and pushed to 8.6.x. Thanks!

  • alexpott committed c3e5648 on 8.6.x 
    Issue #2958293 by rlhawk: Use SerializerAwareTrait instead of extending...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.