Followup to #2875394: Replace all calls to db_query, which is deprecated
grep -inr -e "db_query" core/modules/[p-s]*

CommentFileSizeAuthor
#2 replace_all_db_query_calls-2939393-02-8.6.x.patch11.12 KBvoleger

Comments

voleger created an issue. See original summary.

voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
commented
Assigned: voleger » Unassigned
Status: Active » Needs review
StatusFileSize
new replace_all_db_query_calls-2939393-02-8.6.x.patch11.12 KB
voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
commented
Issue summary: View changes

grep -inr -e "db_query" core/modules/[p-s]*

ankitjain28may’s picture

ankitjain28may commented

The patch in #2 works perfect, Looks good to me, RTBC

joshmiller’s picture

joshmiller
he/him
Primary language English
Location Indianapolis, Indiana, USA
commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work

This patch should be scripted. And done in one issue. See #2849669: Fix \Drupal\Component\Utility\Unicode() because of the Symfony mbstring polyfill and #2958429: Properly deprecate SafeMarkup::format(). The patch should also add an @trigger_error to db_query().

Putting at needs works so that everything can be migrated to #2875394: Replace all calls to db_query, which is deprecated. For more info on why this is the right approach see https://www.drupal.org/core/scope#examples specifically the example of entity_load()

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

@voleger forgot to say thanks for all the work here! Cleaning up the tech debt is something I'm really keen on too and it'll be amazing to get to a point where we're doing a lot less legacy stuff.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
commented
Status: Needs work » Closed (duplicate)

So we will work on the scripted patch.
Follow #2875394: Replace all calls to db_query, which is deprecated