Part of #2924538: [META] Remove all usages of drupal_set_message and drupal_get_messages
grep -inr -e "drupal_set_message" -e "drupal_get_message" core/modules/[m-r]*

CommentFileSizeAuthor
#7 2935258-7.patch24.08 KBkim.pepper
#7 2935258-7-interdiff.txt4.42 KBkim.pepper
#5 2935258-5.patch21.64 KBkim.pepper
#2 2935258-2.patch24.51 KBkim.pepper

Comments

kim.pepper created an issue. See original summary.

kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented
Title: Remove all usages of drupal_get_message and drupal_set_message in modules M-R » [PP-1] Remove all usages of drupal_get_message and drupal_set_message in modules M-R
Status: Active » Postponed
StatusFileSize
new 2935258-2.patch24.51 KB

Initial patch split from parent issue. Blocked on messenger trait in #2935255: Remove all usages of drupal_set_message and drupal_get_messages in core lib

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented
Title: [PP-1] Remove all usages of drupal_get_message and drupal_set_message in modules M-R » Remove all usages of drupal_get_message and drupal_set_message in modules M-R
Status: Postponed » Active
Issue tags: +Needs reroll

Unblocked as messenger trait was added in #2937945: Add messenger to ControllerBase and FormBase

kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented
Status: Active » Needs review
Issue tags: -Needs reroll
StatusFileSize
new 2935258-5.patch21.64 KB

Reroll.

Status: Needs review » Needs work

The last submitted patch, 5: 2935258-5.patch, failed testing. View results

kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented
Status: Needs work » Needs review
StatusFileSize
new 2935258-7-interdiff.txt4.42 KB
new 2935258-7.patch24.08 KB

Add messenger to NodeSearch.

voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
commented
Status: Needs review » Reviewed & tested by the community

Looks good

The last submitted patch, 2: 2935258-2.patch, failed testing. View results

voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
commented
jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Issue summary: View changes

All good as per grep -inr -e "drupal_set_message" -e "drupal_set_message" core/modules/[m-r]*

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Issue summary: View changes
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Closed (duplicate)

Please combine this with the patch in #2935256: Remove all usages of drupal_get_message and drupal_set_message in modules so all the module changes can be reviewed/committed together.