SimpleTest: Remove test results after displayed

Well it doesn't grow exponentially, just linearly.

Also, could you please move the DELETE query *after* the result set from the previous SELECT query has been used. This is probably valid (PHP caches the whole result set), but it makes me itch.

No, I just ask that they are moved *after* the result set from the SELECT query is fully used, ie. after all the db_fetch_object() calls.

I think this patch is very scary. What if one user starts running all tests, and in the middle, another user decides to clean the environment?

I see no real advantages to deleting from the database, and I see possible loss of data (which is a big concern for those of us who take over an hour to run all tests).

Coding style issue:

+  $count = db_result(db_query('SELECT COUNT(test_id)
+                                 FROM {simpletest_test_id}'));

And a big consistency issue:

+/**
+ * Clear the test results tables.
+ */
+function simpletest_clean_results_table() {
+  $count = db_result(db_query('SELECT COUNT(test_id)
+                                 FROM {simpletest_test_id}'));
+
+  // Remove test results.
+  db_query('DELETE FROM {simpletest}');
+  db_query('DELETE FROM {simpletest_test_id}');
+
+  drupal_set_message(t('Removed @count test results.', array('@count' => $count)));
+}

There are THREE different ways to describe the same action:
- "clear" in the doxygen
- "clean" in the function name
- "remove" in the code comments and the dsm call.

Leaving at CNR because it's just coding style issues.

I agree that

SELECT
FROM t1
     t2
     t3
WHERE
  AND
  AND
ORDER BY

is much more readable, and I do this myself as well, but for such a simple query the benefit is lost completely :)

Doing it separately is fine. I did not want to delete once test is over but this is ok.

Looks good to me. Where should we document the variable?

Patch no longer applies and needs a re-roll.

A code review reveals no issues. Should land after a quick re-roll.

Yes, I think I accidentally committed it. Let's mark it fixed.