Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Follow-up to #1203532: jQuery Form Plugin update to latest stable release
Problem/Motivation
jQuery.form got new home so changed it's major version https://github.com/jquery-form/form/releases
https://github.com/jquery-form/form/releases/tag/v4.2.0 points that 4.2.0
jQuery Form is confirmed to be compatible with jQuery 2 and 3!
So for 8.4.0 core it should be updated to be sure that nothing will be broken
Proposed resolution
Update to latest stable release
Remaining tasks
patch, review, commit
User interface changes
no
API changes
no
Comment | File | Size | Author |
---|---|---|---|
#9 | jquery_form_plugin-2899141-9.patch | 32.49 KB | johnchque |
#5 | 2899141-jq-form-5.patch | 32 KB | andypost |
Comments
Comment #2
effulgentsia CreditAttribution: effulgentsia at Acquia commented+1 to doing this. Good to keep our vendor libraries updated whenever possible.
https://github.com/jquery-form/form/releases/tag/v4.2.0 says "jQuery Form is confirmed to be compatible with jQuery 2 and 3!", which is great news. It does not explicitly say that previous versions were not compatible with jQuery3, so recategorizing this issue from bug to task. However, if someone finds a bug with HEAD's jquery.form, or an explicit mention on the jquery-form project that discusses one, then at that time, please set this back to a bug.
Comment #3
andypostHere's initial patch
Comment #4
andypost@effulgentsia thanks, fixed summary
Comment #5
andypostLicence should point to the file according related #2897837: Change the links on core.libraries.yml licenses so they link to the licenses themselves
Comment #6
kwoxer CreditAttribution: kwoxer commentedI had a look on this. But I just wondered why there is a patch for 4.2.1 instead of the latest 4.2.2 Version. (https://github.com/jquery-form/form/releases)
So I would say we should take this version on a new patch here, instead of fixing this one and opening a new issue in some weeks. WDYT?
Comment #7
andypost@kwoxer good catch, please file a patch with 4.2.2 version https://github.com/jquery-form/form/releases/tag/v4.2.2
NW for new patch
Comment #9
johnchqueUsing version 4.2.2. :)
Comment #10
miro_dietikerTested the patch to improve our UX in Paragraphs to avoid false change detection when collapsing unchanged form items. Works very well.
I'd vote to also apply this to the current stable as a bugfix.
Comment #11
miro_dietikerCall to action! :-)
Comment #13
miro_dietikerThat was an infra error.
Comment #14
alexpottComment #16
catchCommitted/pushed to 8.6.x, thanks!
This missed the window for 8.5.0 beta, not sure about backporting there so leaving RTBC against that branch for now.
Comment #17
webchickGiven that we're only a few days away from 8.5.0's release, and our JS testing harness is not as robust as we'd like, there was agreement to keep this in 8.6.x only. However, maybe a workaround for 8.5.0 could be a 'jQuery Form Update' module. ;)
Comment #18
Chi CreditAttribution: Chi commentedFollowup: #2951787: Add missing jquery.form.min.js.map file.