An instruction on /admin/modules reads:

Download additional contributed modules to extend your site's functionality.

It might better read:

Download additional contributed modules or upload a custom module from your computer network to extend your site's functionality.

CommentFileSizeAuthor
#20 Screenshot from 2020-09-17 19-03-29.png254.13 KBranjith_kumar_k_u
#17 Screenshot at 2019-10-30 17-11-49.png152.14 KBGayathri J
#15 Screenshot at 2019-09-16 12-29-44.png102.28 KBshimpy
#14 updated-improved-added-instructions.patch1.46 KBshimpy
#3 improve-added-module-instructions-2889282.patch1.42 KBpramodga

Comments

Charles Belov created an issue. See original summary.

pramodga’s picture

pramodga commented
Assigned: Unassigned » pramodga
pramodga’s picture

pramodga commented
Status: Active » Needs review
StatusFileSize
new improve-added-module-instructions-2889282.patch1.42 KB

@Charles Belov : I've updated the instruction on module listing page as per your comments.

pramodga’s picture

pramodga commented
Assigned: pramodga » Unassigned

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

mayaslatinek’s picture

mayaslatinek commented

Tested the patch provided by @pramodga, the patch applies without problems and updates the add module instructions.

charles belov’s picture

charles belov
he/him
Primary language English
Location San Francisco, CA, US
commented

Works for me as well. Not sure what the threshold is for changing status to Reviewed and Tested by the Community or if I have to be on the commit team to do that.

pramodga’s picture

pramodga commented
Status: Needs review » Fixed
pramodga’s picture

pramodga commented
Status: Fixed » Patch (to be ported)

I have added the patch but still not yet committed. Please commit the patch changes.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Patch (to be ported) » Needs work

Patch to be ported doesn't get patch committed or reviewed. This needs to be reviewed by somebody other then the author and set to "reviewed and tested by the community" (rbtc for short).

+++ b/core/modules/system/system.module
@@ -140,7 +140,7 @@ function system_help($route_name, RouteMatchInterface $route_match) {
+      $output = '<p>' . t('Download additional <a href=":modules">contributed modules</a> to extend your site\'s functionality. Or upload a custom module from your computer network.', [':modules' => 'https://www.drupal.org/project/modules']) . '</p>';

In normal English grammar we try not to start a sentence with a conjunction. This is a bit complex because the upload functionality is only there is the update module is enabled as far as I know. (I might be wrong).

shimpy’s picture

shimpy
Location India
commented
Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new updated-improved-added-instructions.patch1.46 KB

Hii @alexpott as u suggested that the sentence should not be started with the conjunction as per the grammar rules. I have created one patch with some grammar and sentence building changes. Please review. Thanks

shimpy’s picture

shimpy
Location India
commented
StatusFileSize
new Screenshot at 2019-09-16 12-29-44.png102.28 KB

Adding the screenshot as well.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Gayathri J’s picture

Gayathri J commented
StatusFileSize
new Screenshot at 2019-10-30 17-11-49.png152.14 KB

Tested the patch provided by @shimpy, the patch applies added module instructions as per requirement.
image

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

FYI -- on the parent issue #2888657: [meta] Less confusing and more consistent wording needed in module/theme add/install/update the Usability team is discussing the UI text for this and about 10 other issues. Until decisions are made, making another patch here would probably be premature.

ranjith_kumar_k_u’s picture

ranjith_kumar_k_u commented
StatusFileSize
new Screenshot from 2020-09-17 19-03-29.png254.13 KB

I have applied the "updated-improved-added-instructions.patch" patch on drupal 9.1 dev version ,the patch applied cleanly and updates the instruction as per the requirement.Only local images are allowed.

ranjith_kumar_k_u’s picture

ranjith_kumar_k_u commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Postponed

Given #19 let's postpone this on #2888657: [meta] Less confusing and more consistent wording needed in module/theme add/install/update

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

quietone commented
Status: Postponed » Active
quietone’s picture

quietone commented
Status: Active » Closed (outdated)

Now that #3417136: Remove adding an extension via a URL has been committed, this is outdated.