Working on #2870194: Ensure that process-isolated tests can use Symfony's PHPunit bridge to catch usages of deprecated code I performed composer update on core 8.4.x to see what would happen.
As it turns out, this:
- Updating symfony/phpunit-bridge (v3.2.8 => v3.3.0): Loading from cache
[...]
$ ./vendor/bin/phpunit -c core/ --testsuite unit
Fatal error: Declaration of Symfony\Bridge\PhpUnit\SymfonyTestsListener::addSkippedTest(PHPUnit\Framework\Test $test, Exception $e, $time) must be compatible with PHPUnit_Framework_TestListener::addSkippedTest(PHPUnit_Framework_Test $test, Exception $e, $time) in /Users/paul/pj2/drupal/vendor/symfony/phpunit-bridge/SymfonyTestsListener.php on line 70
So we can't currently use phpunit-bridge 3.3.* because we're stuck at phpunit 4.8.* even though it appears that this is an upstream error in version constraints.
In core/composer.json, constrain symfony/phpunit-bridge to 3.2.*
Work on an upstream solution.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | 2882826-6.patch | 2.34 KB | alexpott |
| #5 | 2882826_5.patch | 1.77 KB | mile23 |
| #2 | 2882826_2.patch | 1.77 KB | mile23 |
Comments
Comment #2
mile23We also get a bump to 3.2.9 from 3.2.8.
Comment #4
jibranCan we have a patch for 8.5.x as well?
Comment #5
mile23Updated for 8.5.x, and the patch applies to 8.4.x as well.
Comment #6
alexpottHmmm... this is not what happens for me. If I do the update to 3.3.10 everything works just fine... here's a patch that does the upgrade.
Comment #7
alexpottAlso the current constraint in core/composer.json is
~3.2.8which means it won't allow 3.3.* anyway - see https://getcomposer.org/doc/articles/versions.md#tilde-version-range-Comment #8
mile23Looks like we added the ~ in #2887000: composer.json does not constrain Symfony components to minor and patch versions that are compatible with Drupal which touches both 8.4.x and 8.5.x.
So this is a duplicate.
Thanks. :-)