Follow-up to #2815077: Adopt airbnb javascript style guide v14.1 as new baseline javascript coding standards for Drupal 8 core and contrib

Problem/Motivation

We don't specify any information about supported Node.js versions.

Proposed resolution

Specify a version range in package.json for our supported Node.js version.

CommentFileSizeAuthor
specify-nodejs-version.patch314 bytesGrandmaGlassesRopeMan

Comments

drpal created an issue. See original summary.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

ApacheEx’s picture

ApacheEx commented

@drpal,

it seems already done in 8.6.x.

"engines": {
  "yarn": ">= 1.6",
  "node": ">= 8.11"
},

So, this issue can be closed.

GrandmaGlassesRopeMan’s picture

GrandmaGlassesRopeMan
he/him
Primary language English
Location 🌎
commented
Status: Needs review » Closed (outdated)

This was fixed in #2869825: Leverage JS for JS testing (using nightwatch).