Redundant php open and close tags in Garland theme page templates php file.They should either be removed or appropriate documentation should be added to it.

CommentFileSizeAuthor
#5 drupal7-extra-php-tags-2868584-5.patch11.76 KBcchoudhary
#2 drupal7-extra-php-tags-2868584-2.patch922 bytesgaurav.kapoor

Comments

gaurav.kapoor created an issue. See original summary.

gaurav.kapoor’s picture

gaurav.kapoor commented
Status: Active » Needs review
StatusFileSize
new drupal7-extra-php-tags-2868584-2.patch922 bytes
gaurav.kapoor’s picture

gaurav.kapoor commented
Assigned: gaurav.kapoor » Unassigned
chi’s picture

chi commented

I propose instead of removing it we place file documentation within these tags. Just as it is done in Bartik's templates.

cchoudhary’s picture

cchoudhary commented
StatusFileSize
new drupal7-extra-php-tags-2868584-5.patch11.76 KB

Here is the patch, with file documentation(same as Bartik), instead of removing php tags.

cchoudhary’s picture

cchoudhary commented
poker10’s picture

poker10 commented
Status: Needs review » Needs work

Thanks for working on this!

Personally I think that the approach which adds the documentation is better (#5). However there seems to be some problems:

+++ b/themes/garland/page.tpl.php
@@ -1,4 +1,89 @@
+ * Regions:
+ * - $page['header']: Items for the header region.
+ * - $page['featured']: Items for the featured region.
+ * - $page['highlighted']: Items for the highlighted content region.
+ * - $page['help']: Dynamic help text, mostly for admin pages.
+ * - $page['content']: The main content of the current page.
+ * - $page['sidebar_first']: Items for the first sidebar.
+ * - $page['triptych_first']: Items for the first triptych.
+ * - $page['triptych_middle']: Items for the middle triptych.
+ * - $page['triptych_last']: Items for the last triptych.
+ * - $page['footer_firstcolumn']: Items for the first footer column.
+ * - $page['footer_secondcolumn']: Items for the second footer column.
+ * - $page['footer_thirdcolumn']: Items for the third footer column.
+ * - $page['footer_fourthcolumn']: Items for the fourth footer column.
+ * - $page['footer']: Items for the footer region.

Garland theme does not define any regions in the .info file, so I suppose that only default regions will be available in the page.tpl.php (not all as in the Bartik theme) - see: https://www.drupal.org/docs/7/theming/default-info-values

Also I think it would be better to check the coding standards in the comments, as it seems to me that some comments are longer than 80 characters (see: https://www.drupal.org/node/1354).

Thanks!

Status: Needs work » Closed (outdated)

Automatically closed because Drupal 7 security and bugfix support has ended as of 5 January 2025. If the issue verifiably applies to later versions, please reopen with details and update the version.