The problem

Path processors rely on the the language providing the language for the path that they are processing. See AliasManager. When matching a route for a request the path processors are ran, but if they are run after the master request they will always get the language for the master request.

Proposed solution

In the language manager store negotiated languages per request. This would mean that there needs to be a way to generate a key for a request (path + query ?). Also there needs to be a way to override the request stored in the language manager. By default it should be the current request from the request stack.

The LanguageManagerInterface should provide a method for setOverrideRequest(), removeOverrideRequest().
There should also be a method to generate key from request and a method for getting the request for which the language manager should negotiate language.

The impact of this change would be none.

Comments

_Archy_ created an issue. See original summary.

_Archy_’s picture

_Archy_ commented
Related issues: +#2802403: Combination of language negotiation and path aliasing can cause a corrupted route cache, 404s

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

_Archy_’s picture

_Archy_ commented
Status: Active » Closed (duplicate)
Related issues: +#2940036: Path processors are fixated to current request and not the processed request