Unmet installation requirements may contain render elements

I came across this issue while testing the new command line tool to install and run Drupal.
https://www.drupal.org/node/2969396

System module is using inline Twig templates for rendering descriptions to avoid double escaping. I think an alternative solution could be using Formatable markup as it implements __toString() magic method.

Yes, this patch is working for me.

Nice find!

      $failures = [];
      foreach ($requirements as $requirement) {
        // Skip warnings altogether for non-interactive installations; these
        // proceed in a single request so there is no good opportunity (and no
        // good method) to warn the user anyway.
        if (isset($requirement['severity']) && $requirement['severity'] == REQUIREMENT_ERROR) {
          $failures[] = $requirement['title'] . ': ' . $requirement['value'] . "\n\n" . $requirement['description'];
        }
      }
      if (!empty($failures)) {
        throw new InstallerException(implode("\n\n", $failures));
      }

I think we should do something like:

      // Throw an exception showing any unmet requirements.
      $failures = [];
      foreach ($requirements as $requirement) {
        // Skip warnings altogether for non-interactive installations; these
        // proceed in a single request so there is no good opportunity (and no
        // good method) to warn the user anyway.
        if (isset($requirement['severity']) && $requirement['severity'] == REQUIREMENT_ERROR) {$failures[] = $requirement['title'] . ': ' . $requirement['value'] . "\n\n" . $requirement['description'];
          $failures[] = \Drupal::service('renderer')->renderPlain([
            '#type' => 'inline_template',
            '#template' => '{{ title }}:{{ value }}<br /><br />{{ description }}',
            '#context' => [
              'title' => $requirement['title'],
              'value' => $requirement['value'],
              'description' => $requirement['description'],
            ],
          ]);
        }
      }
      if (!empty($failures)) {
        throw new InstallerException(\Drupal\Component\Render\PlainTextOutput::renderFromHtml(implode("<br /><br />", $failures)));
      }

• title and value can also be render elements
• There can be html in the description which is not good for CLI output

We also should test this somehow.

In install.core.inc line 2289:

PHP extensions: Disabled

Array
-------------------------------------------
https://www.drupal.org/docs/official_docs/en/_evaluator_guide.html

https://www.drupal.org/docs/8/system-requirements/php-requirements

This is still happening in drupal-8.7.2

Thank you so much for this patch. Although I'm currently running Drupal 8.9.2, it was still useful. I was just getting an error that said

...
[info] Array to string conversion install.core.inc:2303 [12.86 sec, 11.3 MB]

In install.core.inc line 2307:
                                                        
  [Drupal\Core\Installer\Exception\InstallerException]  
  File system:                                          
                                                        
  Array                                                 
                                                        

Exception trace:
  at /var/www/docroot/core/includes/install.core.inc:2307
 install_display_requirements() at /var/www/docroot/core/includes/install.core.inc:1088
 install_verify_requirements() at /var/www/docroot/core/includes/install.core.inc:701
...

Which is not helpful in any way whatsoever. I applied the patch and I at least now have something I can troubleshoot.

 [notice] Performed install task: install_load_profile [12.54 sec, 11.23 MB]

In install.core.inc line 2308:
                                                                                                                                     
  [Drupal\Core\Installer\Exception\InstallerException]                                                                               
  File system:                                                                                                                       
                                                                                                                                     
  The directory <em class="placeholder">/mnt/gfs/./tmp</em> does not exist. An automated attempt to create this directory failed, p  
  ossibly due to a permissions problem. To proceed with the installation, either create the directory and modify its permissions ma  
  nually or ensure that the installer has the permissions to create it automatically. For more information, see INSTALL.txt or the   
  <a href="https://www.drupal.org/server-permissions">online handbook</a>.                                                           
                                                                                                                                     

Exception trace:
  at /var/www/docroot/core/includes/install.core.inc:2308
 install_display_requirements() at /var/www/docroot/core/includes/install.core.inc:1088

I came here after receiving the following message during site installation and having no idea what to do next 😃

In install.core.inc line 2293:          
  Database settings:
  Array

I've updated the issue summary and marked another one as duplicated: #3081572: Unexpected description format when parsing the unmet requirements message string (by the way, the IS is very detailed and IMO deserving a credit here).

We still need a patch here, so I'm leaving the current status.

Wasted many hours today because of this - in our environment access to core/install.php is blocked on webserver level for security reasons.

Attaching the patch I done as a workaround based on #5 - thanks @Chi!

It;s not ideal, but it works.

Improved version - based on #8.

In 9.3, the above was giving me:

Error: Cannot pass parameter 1 by reference in /path/to/drupal/core/includes/install.core.inc on line 2299

Here's an updated patch (for 9.3) and interdiff.

Closed #3247337: Quick Start: Missing PHP extensions shown as "Array" as duplicate

#21 has failed coding standard checks and needs a bit of work.

Adding Drupal Quick Start Command in Issue Summary.

Here's an updated patch, which removes the tab with spaces and an interdiff.

The patch works well, and an error message is shown, though with HTML, so this bit from the Issue Summary is still relevant:

- There can be html in the description which is not good for CLI output

Before:

In install.core.inc line 2306:

  Database settings:

  Array

After:

In install.core.inc line 2313:

  Database settings:<br /><br />Resolve all issues below to continue the installation. For help configuring your database server
  , see the <a href="https://www.drupal.org/docs/8/install">installation handbook</a>, or contact your hosting provider.<div cla
  ss="item-list"><ul><li>The database server version <em class="placeholder">3.24.0</em> is less than the minimum required versi
  on <em class="placeholder">3.26</em>.</li></ul></div>

Yes, the HTML tags are still not ideal, but the perfect is the enemy of the good and this bug is an absolute PITA. So IMO let's get this in, and stripping the HTML tags can be figured out as a follow-up.

Test failure looks weird and random?

This is way better that what is in HEAD - getting the info is preferable. But we can do better. Let's to this is a follow-up though because I think there is a few things to discussed. If we use throw new InstallerException(MailFormatHelper::htmlToText(implode("\n\n", $failures))); then the output goes from:

to:

Before we go ahead and commit a fix, can you have a look at my comment #2833864-18: Unmet installation requirements may contain render elements?
I suggested crediting @zoiosilva for filling #3081572: Unexpected description format when parsing the unmet requirements message string - the report was very comprehensive and contains some suggestions too.

Creditting @zoiosilva as per @Matroskeen

Crediting @loopy1492 and @joachim for the manual test evidence - given this one is hard to test and we've not managed to write an automated test.

Committed and pushed 3242f339f1 to 10.0.x and e2e4b11b97 to 9.4.x and 2902531a85 to 9.3.x. Thanks!

Opened the follow-up #3266441: Consider methods to remove HTML from requirements messages displayed during a non-interactive install