Write EntityResourceTestBase subclasses for: MenuLinkContent

Woot, thanks Rob!

To answer your questions regarding access handling: you're right that it's strange right now. We have similar strangeness for vocabulary & term entities, we have #2808217: To be able to view Vocabulary config entities via REST, one should not have to grant the 'administer taxonomy' permission + #2824408: To be able to create/update/delete Term entities via REST, one should not have to grant the 'administer taxonomy' permission to fix that. You could open a similar issue for menu_link_content entities (but please don't do it in this issue, that would be out of scope). I think it'd make sense to add a more granular permission for viewing Menu Link content entities.

1. This is missing a JSON + cookie test.

2. +++ b/core/modules/hal/tests/src/Functional/EntityResource/MenuLinkContent/MenuLinkContentHalJsonAnonTest.php
   @@ -0,0 +1,46 @@
   + * MenuLinkContent anonymous hal json test.
   
   +++ b/core/modules/hal/tests/src/Functional/EntityResource/MenuLinkContent/MenuLinkContentHalJsonBasicAuthTest.php
   @@ -0,0 +1,33 @@
   + * MenuLinkContent basic auth hal json test.
   

   The other EntityResourceTest subclasses also don't have these comments, so let's not start doing so here.

3. +++ b/core/modules/rest/tests/src/Functional/EntityResource/MenuLinkContent/MenuLinkContentResourceTestBase.php
   @@ -0,0 +1,185 @@
   +  protected function setUpAuthorization($method) {
   +    switch ($method) {
   +      case 'GET':
   +        $this->grantPermissionsToTestedRole(['administer menu']);
   +        break;
   +
   +      case 'POST':
   +      case 'PATCH':
   +      case 'DELETE':
   +        $this->grantPermissionsToTestedRole(['administer menu']);
   +        break;
   +    }
   +  }
   

   All HTTP methods require the same permission for now, so we can simplify this.

Woah, @webflo is in the house! I didn't know you were working on REST stuff :)

I work on it during SprintWeekend.

@webflo, i'm also working on similar issue, https://www.drupal.org/node/2843750 and following you on this. Any directions for me??

Some progress on hal+json.

+++ b/core/modules/rest/tests/src/Functional/EntityResource/EntityResourceTestBase.php
@@ -561,7 +561,7 @@ public function testPost() {
-    $label_field_capitalized = ucfirst($label_field);
+    $label_field_capitalized = $this->entity->getFieldDefinition($label_field)->getLabel();

@@ -751,7 +751,7 @@ public function testPatch() {
-    $label_field_capitalized = ucfirst($label_field);
+    $label_field_capitalized = $this->entity->getFieldDefinition($label_field)->getLabel();

Nice improvements to the base test class! :)

This looks perfect, thanks! :)

Committed ef0a872 and pushed to 8.4.x. Thanks!
Committed 48ec098 and pushed to 8.3.x. Thanks!

diff --git a/core/modules/hal/tests/src/Functional/EntityResource/MenuLinkContent/MenuLinkContentHalJsonBasicAuthTest.php b/core/modules/hal/tests/src/Functional/EntityResource/MenuLinkContent/MenuLinkContentHalJsonBasicAuthTest.php
index eb5e705..3af8362 100644
--- a/core/modules/hal/tests/src/Functional/EntityResource/MenuLinkContent/MenuLinkContentHalJsonBasicAuthTest.php
+++ b/core/modules/hal/tests/src/Functional/EntityResource/MenuLinkContent/MenuLinkContentHalJsonBasicAuthTest.php
@@ -2,7 +2,6 @@
 
 namespace Drupal\Tests\hal\Functional\EntityResource\MenuLinkContent;
 
-use Drupal\Tests\hal\Functional\EntityResource\MenuLinkContent\MenuLinkContentHalJsonAnonTest;
 use Drupal\Tests\rest\Functional\BasicAuthResourceTestTrait;
 
 /**
diff --git a/core/modules/rest/tests/src/Functional/EntityResource/MenuLinkContent/MenuLinkContentJsonBasicAuthTest.php b/core/modules/rest/tests/src/Functional/EntityResource/MenuLinkContent/MenuLinkContentJsonBasicAuthTest.php
index 9be9e55..952088b 100644
--- a/core/modules/rest/tests/src/Functional/EntityResource/MenuLinkContent/MenuLinkContentJsonBasicAuthTest.php
+++ b/core/modules/rest/tests/src/Functional/EntityResource/MenuLinkContent/MenuLinkContentJsonBasicAuthTest.php
@@ -3,7 +3,6 @@
 namespace Drupal\Tests\rest\Functional\EntityResource\MenuLinkContent;
 
 use Drupal\Tests\rest\Functional\BasicAuthResourceTestTrait;
-use Drupal\Tests\rest\Functional\JsonBasicAuthWorkaroundFor2805281Trait;
 
 /**
  * @group rest
diff --git a/core/modules/rest/tests/src/Functional/EntityResource/MenuLinkContent/MenuLinkContentJsonCookieTest.php b/core/modules/rest/tests/src/Functional/EntityResource/MenuLinkContent/MenuLinkContentJsonCookieTest.php
index 155b853..73b4567 100644
--- a/core/modules/rest/tests/src/Functional/EntityResource/MenuLinkContent/MenuLinkContentJsonCookieTest.php
+++ b/core/modules/rest/tests/src/Functional/EntityResource/MenuLinkContent/MenuLinkContentJsonCookieTest.php
@@ -1,10 +1,5 @@
 <?php
 
-/**
- * @file
- * Contains \Drupal\Tests\rest\Functional\EntityResource\MenuLinkContent\MenuLinkContentJsonCookieTest.
- */
-
 namespace Drupal\Tests\rest\Functional\EntityResource\MenuLinkContent;
 
 use Drupal\Tests\rest\Functional\CookieResourceTestTrait;
diff --git a/core/modules/rest/tests/src/Functional/EntityResource/MenuLinkContent/MenuLinkContentResourceTestBase.php b/core/modules/rest/tests/src/Functional/EntityResource/MenuLinkContent/MenuLinkContentResourceTestBase.php
index 37117eb..ee886c0 100644
--- a/core/modules/rest/tests/src/Functional/EntityResource/MenuLinkContent/MenuLinkContentResourceTestBase.php
+++ b/core/modules/rest/tests/src/Functional/EntityResource/MenuLinkContent/MenuLinkContentResourceTestBase.php
@@ -170,7 +170,7 @@ protected function getExpectedNormalizedEntity() {
            'value' => '1',
          ],
        ],
-      'parent' => [],
+       'parent' => [],
      ];
   }
 

Coding standards fixed on commit.

Unfortunately, this seems to be failing in HEAD, so I reverted it. I'll add retests on the patch.

E.g.: https://www.drupal.org/pift-ci-job/596766

Ah yes, the failing tests make sense: this needs a reroll after #2808233: REST 403 responses don't tell the user *why* access is not granted: requires deep Drupal understanding to figure out.

Apparently the RTBC queue is so long that testbot didn't actually do that yet, despite it landing about 2 days before this got committed.

Patch applies successfully on both 8.3.x and 8.4.x so does not appear to be a re-roll, but still Needs Work to address test failures.

#28: no that means this entity type has unauthorized access error messages that deviate from the default ones. That's fine.

It means we just need to override getExpectedUnauthorizedAccessMessage(). For an example, see \Drupal\Tests\rest\Functional\EntityResource\User\UserResourceTestBase::getExpectedUnauthorizedAccessMessage().

All three errors are about that AFAICT :)

+++ b/core/modules/rest/tests/src/Functional/EntityResource/MenuLinkContent/MenuLinkContentResourceTestBase.php
@@ -0,0 +1,193 @@
+       'uuid' => [

Nit: indentation. Thanks :)

I compared #17 and #35 by applying both locally, and diffing them. Because it also fixes an indentation issue, I also had to use --word-diff.

This looks perfect.

Thanks!

As of #2577923-106: MenuLinkContent entities pointing to nodes are not deployable: LinkItem should have a "target_uuid" computed property, this is a blocker for #2577923.

Committed and pushed e4461e6 to 8.4.x and 0dcbf65 to 8.3.x. Thanks!

I've backported this to 8.3.x as it 99.9% additional test coverage and the remainer just helps with REST adoption and has no BC concerns.

+++ b/core/modules/menu_link_content/src/MenuLinkContentAccessControlHandler.php
@@ -56,7 +56,7 @@ protected function checkAccess(EntityInterface $entity, $operation, AccountInter
-          return AccessResult::neutral()->cachePerPermissions();
+          return AccessResult::neutral("The 'administer menu' permission is required.")->cachePerPermissions();

This is the one non test change in the patch and it's helpful and totally non-controversial.

Awesome :) Thanks, @alexpott, for your thoughtfulness!

@vaplas: thanks for explaining the reason for that change so clearly! I'm sure it'll be helpful for future readers.

EntityResourceTestBase is a very cool, because it makes necessary to correct such places :)

I'm glad you feel that way :)