Problem/Motivation

When I run eslint checking on core's js files I get the following error:

/Volumes/devdisk/dev/drupal/core/themes/seven/js/nav-tabs.js
   8:1  error  Use the global form of 'use strict'  strict
  10:3  error  Use the global form of 'use strict'  strict

For nearly all of the files.

This is a major bug because javascript linting is part of every core committer's commit workflow.

Proposed resolution

Fix ./core/.eslintrc

Remaining tasks

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#5 2821113-5.patch399 bytesalexpott
#2 2821113-2.patch743 bytesalexpott
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Active » Needs review
FileSize
2821113-2.patch743 bytes

Status: Needs review » Needs work

The last submitted patch, 2: 2821113-2.patch, failed testing.

droplet’s picture

droplet CreditAttribution: droplet commented

Hmm. We all running an old version before :)

overlapped #2809343: Add ESLint to package.json, would you like to commit that one and cherry-pick ?

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Needs work » Needs review
FileSize
2821113-5.patch399 bytes

This has been fixed in 8.3.x by #2809343: Add ESLint to package.json but I think we should fix this in 8.2.x too.

droplet’s picture

droplet CreditAttribution: droplet commented
Status: Needs review » Reviewed & tested by the community

OK. Ran with eslint@3.8.1, no more errors. Thanks!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Priority: Major » Normal
Status: Reviewed & tested by the community » Fixed

Committed ab23dc9 and pushed to 8.2.x. Thanks!

  • alexpott committed ab23dc9 on 8.2.x 
    Issue #2821113 by alexpott: eslint 'use strict' rule wrong

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.