Problem/Motivation
See #2721179: Replace deprecated Symfony ExecutionContextInterface and the discussion in https://github.com/symfony/symfony/issues/20088
We have two classes in core that implement both ConstraintInterface and ConstraintValidatorInterface, @stof from Symfony was surprised by this since the responsibilities are very different. Also that complicated the Symfony 2.8-3.0 upgrade path for us a fair bit.
Proposed resolution
2. See if we can split them out into separate classes.
Remaining tasks
User interface changes
API changes
Data model changes
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | 2810367.patch | 21.29 KB | catch |
| #7 | 2810367.patch | 20.5 KB | catch |
| #6 | 2810367.patch | 20.56 KB | catch |
| #3 | 2810367.patch | 20.4 KB | catch |
| #2 | 2810367.patch | 17.11 KB | catch |
Comments
Comment #2
catchPatch based on #2721179: Replace deprecated Symfony ExecutionContextInterface. With this we wouldn't need the base class added in the other issue.
Comment #3
catchHelps when you add the files.
Comment #6
catchSilliness.
Comment #7
catchNow minus the new base class.
Comment #9
catchNeed to reference $message on the constraint now it's not on the validator.
Comment #11
catchMoving back to #2721179: Replace deprecated Symfony ExecutionContextInterface.