Problem/Motivation

See #2721179: Replace deprecated Symfony ExecutionContextInterface and the discussion in https://github.com/symfony/symfony/issues/20088

We have two classes in core that implement both ConstraintInterface and ConstraintValidatorInterface, @stof from Symfony was surprised by this since the responsibilities are very different. Also that complicated the Symfony 2.8-3.0 upgrade path for us a fair bit.

Proposed resolution

2. See if we can split them out into separate classes.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#9 2810367.patch21.29 KBcatch
#7 2810367.patch20.5 KBcatch
#6 2810367.patch20.56 KBcatch
#3 2810367.patch20.4 KBcatch
#2 2810367.patch17.11 KBcatch

Comments

catch created an issue. See original summary.

catch’s picture

Status: Active » Needs review
StatusFileSize
new17.11 KB

Patch based on #2721179: Replace deprecated Symfony ExecutionContextInterface. With this we wouldn't need the base class added in the other issue.

catch’s picture

StatusFileSize
new20.4 KB

Helps when you add the files.

The last submitted patch, 2: 2810367.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 3: 2810367.patch, failed testing.

catch’s picture

Status: Needs work » Needs review
StatusFileSize
new20.56 KB

Silliness.

catch’s picture

StatusFileSize
new20.5 KB

Now minus the new base class.

The last submitted patch, 6: 2810367.patch, failed testing.

catch’s picture

StatusFileSize
new21.29 KB

Need to reference $message on the constraint now it's not on the validator.

The last submitted patch, 7: 2810367.patch, failed testing.

catch’s picture

Status: Needs review » Closed (duplicate)