API page: https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Entity%21...

> \Drupal\Core\Entity\EntityTypeInterface $bundle_entity_type: The ID of the bundle entity type.

If the param is an interface, it's not an ID.

CommentFileSizeAuthor
#6 incorrect_param_EntityController_2802593_6.patch700 byteskarlosgliberal
#3 incorrect_param_ EntityController_2802593_3.patch694 bytesarunkumark
#2 D8-incorrect-param-2802593-2.patch700 bytespushpinderchauhan

Comments

joachim created an issue. See original summary.

pushpinderchauhan’s picture

pushpinderchauhan commented
Status: Active » Needs review
StatusFileSize
new D8-incorrect-param-2802593-2.patch700 bytes

Just giving it a try.

arunkumark’s picture

arunkumark
Location Coimbatore
commented
StatusFileSize
new incorrect_param_ EntityController_2802593_3.patch694 bytes

Created a patch by referring previous API documentations,
Reference:
1) https://api.drupal.org/api/drupal/core!lib!Drupal!Core!Entity!EntityInte...
2) https://api.drupal.org/api/drupal/core!lib!Drupal!Core!Entity!EntityHand...

Status: Needs review » Needs work

The last submitted patch, 3: incorrect_param_ EntityController_2802593_3.patch, failed testing.

joachim’s picture

joachim commented

I think the patch in #2 looks fine. Patch #3 is failing tests, and also doesn't say it's the bundle.

karlosgliberal’s picture

karlosgliberal commented
Version: 8.2.x-dev » 8.3.x-dev
Assigned: Unassigned » karlosgliberal
Status: Needs work » Needs review
StatusFileSize
new incorrect_param_EntityController_2802593_6.patch700 bytes

Mixed both patches into one file.

joachim’s picture

joachim commented
Status: Needs review » Reviewed & tested by the community

Looks good!

  • catch committed 9bdda95 on 8.3.x 
    Issue #2802593 by arunkumark, er.pushpinderrana, karlosgliberal, joachim...

  • catch committed f59cccf on 8.2.x 
    Issue #2802593 by arunkumark, er.pushpinderrana, karlosgliberal, joachim...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.3.x and cherry-picked to 8.2.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

xjm’s picture

xjm
she/her
Primary language English
commented

Correcting issue credit.