This is in Drupal\views\Plugin\views\HandlerBase

CommentFileSizeAuthor
#3 interdiff-2795793-2-3.txt797 bytesmarkdorison
#3 missing_params_and-2795793-3.patch702 bytesmarkdorison
#2 acceptExposedInput_doc-2795793-2.patch684 bytesshashikant_chauhan

Comments

joachim created an issue. See original summary.

shashikant_chauhan’s picture

shashikant_chauhan commented
Assigned: Unassigned » shashikant_chauhan
Status: Active » Needs review
StatusFileSize
new acceptExposedInput_doc-2795793-2.patch684 bytes

Adding patch.

markdorison’s picture

markdorison
he/him
commented
StatusFileSize
new missing_params_and-2795793-3.patch702 bytes
new interdiff-2795793-2-3.txt797 bytes
  • Fixed trailing whitespace.
  • Added detail to @return message.
ricardoamaro’s picture

ricardoamaro commented 
+++ b/core/modules/views/src/Plugin/views/HandlerBase.php
@@ -557,12 +557,13 @@ public function multipleExposedInput() { return FALSE; }
-   *   TRUE if the input for this filter should be included in the view query.

This looks fine.

ricardoamaro’s picture

ricardoamaro commented
Status: Needs review » Reviewed & tested by the community

re-checking

sutharsan’s picture

sutharsan commented
Status: Reviewed & tested by the community » Needs work

@ricardoamaro, thanks for working on this. Please describe what you have checked that resulted in your conclusion. That will give other insight what you have done, how thorough you have investigated this. For example have you looked at various implementation of acceptExposedInput(), have you looked at the code calling acceptExposedInput(), to find out that the @param and @return descritions are correct.

ricardoamaro’s picture

ricardoamaro commented

@sutharsan, thanks for the heads up.
While you mentioned it i went back to give a look to the second patch and noticed that while it improves the first patch, it adds a line that is not conclusive that it could be correct.
While other classes with acceptExposedInput, that override this function, in core, return TRUE or FALSE, this one one only returns TRUE, therefore the patch needs to be rechecked by a more deeper insight into the usage of
To conclude, i only have doubts regarding acceptExposedInput returning FALSE in this Class. It surely returns TRUE.

ricardoamaro’s picture

ricardoamaro commented
Issue tags: -Novice

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

quietone commented
Category: Bug report » Task
Status: Needs work » Closed (outdated)
Issue tags: +Bug Smash Initiative

Thanks for working to improve the documentation in core.

Missing documentation is not a bug, it is a task. These changes are done by sniff now so I am marking this as outdated and applying credit to one of the related issues, #3207949: Fix Drupal.Commenting.FunctionComment.MissingParamType

Thanks!