Problem/Motivation

Wim Leers in #2753941-164: [Experimental] Create Outside In module MVP to provide block configuration in Off-Canvas tray and expand site edit mode said 

+++ b/core/modules/outside_in/css/outside_in.module.css
@@ -0,0 +1,200 @@
+ * Form layout changes, mostly specific to Bartik theme and menu.

Then let's move these in a separate CSS file, so that it's easier to move it into Bartik once this module becomes non-experimental.

Proposed resolution

Even better, we can simply remove the reference to Bartik altogether since the module will have it's own CSS that will cover all themes.

Remaining tasks

Remove the reference to Bartik.

User interface changes

N/A

API changes

N/A

Data model changes

N/A

Comments

tim.plunkett created an issue. See original summary.

xjm’s picture

xjm
she/her
Primary language English
commented
Issue tags: +Outside-in
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Component: quickedit.module » outside_in.module
Issue tags: -Outside-in
tkoleary’s picture

tkoleary commented
Status: Active » Closed (won't fix)

The comment in this CSS references Bartik theme because it was decided to build the MVP so that it inherited styles from Bartik. Now that the module has been committed that's no longer the case.

It was never intended, and should NOT be the case that these styles get moved into Bartik. Rather, the solution is creating specific styling for the tray in the module itself, at which point we can remove the comment.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Closed (won't fix) » Active 
/*
 * Form layout changes, mostly specific to Bartik theme and menu.
 * @todo Remove when more general form styling is done:
 *    https://www.drupal.org/node/2784437.
 */

@tkoleary
So part of this comment is no longer relevant?

If any we need to remove.

tkoleary’s picture

tkoleary commented

@tedbow

Yes. Any styling there will just be unique to the module. I passed a bunch of CSS from my local branch to Tim to add there as part of the style-as-designed issue.

tkoleary’s picture

tkoleary commented
Title: Move Bartik-specific Outside-In CSS into Bartik directly » Remove reference to Bartik form outside-in CSS
Issue summary: View changes
tkoleary’s picture

tkoleary commented
Title: Remove reference to Bartik form outside-in CSS » Remove reference to Bartik in outside-in CSS
Bojhan’s picture

Bojhan commented

@Kevin Can we review that somewhere your stylistic changes?

tkoleary’s picture

tkoleary commented

@bojhan

I will update them in #2781577: Properly style outside-in off canvas tray

tkoleary’s picture

tkoleary commented
Status: Active » Closed (fixed)
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Component: outside_in.module » settings_tray.module

Changing to new settings_tray.module component. @drpal thanks for script help! :)