Problem/Motivation

Achieving dream markup in form is difficult since it is difficult to add attributes for form element labels.

Proposed resolution

Allow form elements to set attributes for the label of the element.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#8 2774255-8.patch1.74 KBjoelpittet
#8 interdiff.txt893 bytesjoelpittet
#2 allow_form_element_to-2774255-2.patch885 byteslauriii

Comments

lauriii created an issue. See original summary.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
StatusFileSize
new allow_form_element_to-2774255-2.patch885 bytes
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

@lauriii what is this postponed on?

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented

Attributes cannot be passed to form_element_label until we have fixed this: #2774195: Passing attributes to field element label is not possible

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Postponed » Needs review

This is not postponed anymore

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Issue tags: +Needs tests

Could use one test to check the label attribute gets added otherwise I think this is good to go.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Issue tags: -Needs tests
StatusFileSize
new interdiff.txt893 bytes
new 2774255-8.patch1.74 KB

Here's a test

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Needs review » Reviewed & tested by the community

Tests look good!

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 8: 2774255-8.patch, failed testing.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Needs work » Reviewed & tested by the community

I don't see any fails

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 8: 2774255-8.patch, failed testing.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Needs work » Reviewed & tested by the community

Looks like unrelated fail again

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

  • catch committed 622a354 on 8.3.x 
    Issue #2774255 by joelpittet, lauriii: Allow form element to set...
andypost’s picture

andypost
he/him
Primary language Russian
commented

Why there's no change record?

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.