This is a followup of #2767269: LocalReadOnlyStream must declare itself not writeable. We made there LocalReadOnlyStream return the correct type in terms of writability but we forgot to add the StreamWrapperInterface::LOCAL bit to the stream wrapper type composite bit pack. Right now LocalReadOnlyStream doesn't say that is a local stream wrapper.
The attached patch proves the bug.
Add the StreamWrapperInterface::LOCAL to the returned value of LocalReadOnlyStream::getType().
None.
None.
None.
None.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | 2770339-4-8.2.x.patch | 1.28 KB | claudiu.cristea |
| #5 | 2770339-4.patch | 1.27 KB | claudiu.cristea |
| localreadonlystream_local_bit-test-only.patch | 788 bytes | claudiu.cristea |
Comments
Comment #2
claudiu.cristeaComment #3
claudiu.cristeaAnd it's a 8.1.x issue.
Comment #5
claudiu.cristeaBig proved. I posted 2 patches because in 8.2.x the test has moved to a phpunit KernelTestBase.
Comment #7
claudiu.cristeaOuch, 8.2.x should be tested with 8.2.x :)
Comment #8
amateescu commentedLooks good to me.
Comment #9
alexpottCommitted 019b604 and pushed to 8.1.x. Thanks!
Committed 3bda71d and pushed to 8.2.x. Thanks!