Problem/Motivation

\Drupal\Tests\views\FunctionalJavascript\ExposedFilterAJAXTest::waitForAjaxToFinish is a helpful method that is currently defined in a specific test.
#2745953: AjaxBasePageNegotiator should not require _theme: ajax_base_page to be specified will add the exact same method to another test.

Proposed resolution

Move it up to the base class.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#3 move-wait-for-ajax-to-finish-to-base-class-2747863-3.patch1.45 KBmarcoscano

Comments

tim.plunkett created an issue. See original summary.

dawehner’s picture

dawehner
Primary language German
commented

+1 for moving it to the base class. I'm wondering whether 10 seconds is too much for timeout, but on the other hand, this is really just a problem in case there is another problem, so whatever.

marcoscano’s picture

marcoscano
Primary language Portuguese, Brazil
Location Barcelona, Spain
commented
Status: Active » Needs review
StatusFileSize
new move-wait-for-ajax-to-finish-to-base-class-2747863-3.patch1.45 KB
webflo’s picture

webflo commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +DevDaysMilan

Yes please.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 3: move-wait-for-ajax-to-finish-to-base-class-2747863-3.patch, failed testing.

webflo’s picture

webflo commented
Status: Needs work » Closed (won't fix)

#2648956: Editing a view leaves old keys hanging, results in invalid schema introduced $this->assertSession()->assertWaitOnAjaxRequest();. Flagging this a won't fix.