forum_uninstall has this line in it:

db_query("DELETE FROM {node} WHERE type = 'forum'");

1. It's not using the node API - so {comments}, CCK fields, {node_revisions}, {node_comment_statistics} and anything else will be left stale in the DB.
2. AFAIK, book.module doesn't delete book nodes etc. forum topics can and are used in places other than forums.
3. No warning is given that it's going to simply delete all that data

IMO, just remove it.

CommentFileSizeAuthor
#3 forum_uninstall-d5.patch650 bytescatch
forum_uninstall_craziness.patch680 bytescatch

Comments

nedjo’s picture

nedjo
he/him/his
Primary language English
commented

It's an open question what should happen with the orphan data associated with these nodes, but yes, simply deleting the node table rows is wrong and in many cases will leave the install in a worse state than leaving them there.

Looks like we should delete this line as suggested and wait for a real solution.

dries’s picture

dries commented
Status: Needs review » Fixed

I've committed this to DRUPAL-6 and CVS HEAD. The behavior is inconsistent with that of other node modules, it seems. At least, it is consistent now.

catch’s picture

catch
he/him
Primary language English
commented
Version: 7.x-dev » 5.x-dev
Status: Fixed » Needs review
StatusFileSize
new forum_uninstall-d5.patch650 bytes

Thanks.

Here's a version for D5 - exactly the same issue there.

drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Needs review » Fixed

Committed to 5.x.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.