Mark MissingDependentModuleUnitTest as incomplete

Over in #2721355: MissingDependentModuleUnitTest has the wrong namespace @alexpott says "@neclimdul actually I think your real fix is the right fix :)" in response to "Maybe the real fix is this should be moved back to simpletest since its testing its discovery."

Therefore I'm updating the summary and setting this to needs work.

I'm re-opening this because #2728579: Explicitly skip @requires module in PHPUnit Kernel and Browser tests has a wider scope and really all I want is passing tests right now. :-)

If i say:

./vendor/bin/phpunit -c core/ --group simpletest --testsuite functional

I get:

There was 1 failure:

1) Drupal\Tests\simpletest\Functional\MissingDependentModuleUnitTest::testFail
Running test with missing required module.

/Users/paulmitchum/projects/drupal8/core/modules/simpletest/tests/src/Functional/MissingDependentModuleUnitTest.php:19

If we want to leave MissingDependentModuleUnitTest as a Kernel test, then we should mark it as skipped or incomplete.

Also rename it so it doesn't have Unit in the name.

So this test was wrongly converted from Simpletest to PHPUnit in #2770921: Feb 21st: Convert chunk of WTB to BTB by just moving classes, changing use statements adding traits.

I think we should just move this test back to Simpletest to keep the test coverage there. Then continue at #2728579: Explicitly skip @requires module in PHPUnit Kernel and Browser tests to finish the @require module support in PHPUnit.

Unfortunately, it still fails when it's a WTB and you run it directly, since only TestDiscovery enforces @dependencies.

When you look at this behavior in TestDiscovery here: http://cgit.drupalcode.org/drupal/tree/core/modules/simpletest/src/TestD...

...you see that it has a @todo for #1273478: Implement @requires and @dependencies within TestBase, mark tests as skipped which is a long-standing task which is still open. MissingDependentModuleUnitTest is really a test of that behavior, since it can (and does) fail depending on how you run it, which means that it's incomplete as a WTB as well.

Either way it's incomplete, and an annoyance for the thing I'm trying to accomplish, which is this: #2296615: Accurately support multiple @groups per test class

Also, if it's meant to be finished in #2728579: Explicitly skip @requires module in PHPUnit Kernel and Browser tests then it shouldn't be a WTB test in the first place.

OK, since this is broken anyway I agree about marking it as incomplete.

The thing is at the moment this is the only test coverage of @dependencies so if we do this and we change TestDiscovery and break it then we won't know. I think just need to do #2728579: Explicitly skip @requires module in PHPUnit Kernel and Browser tests and not lose this test coverage. If you want to run all the functional tests use run-tests.sh or use --exclude-group simpletest because people outside of the core test runs want to test the simpletest code.

OK, so we have work happening on #2728579: Explicitly skip @requires module in PHPUnit Kernel and Browser tests and its follow-up #2857977: Support @require module in BrowserTestBase tests since it seems we're not going to simply mark this test incomplete or delete it. Note that #2728579-27: Explicitly skip @requires module in PHPUnit Kernel and Browser tests deletes the test from this issue in favor of two tests that are falsifiable.

I'll just put off #2296615: Accurately support multiple @groups per test class until the yak is shaved, by which time there will be zero people with momentum on any of it.

OK, so let's continue at #2728579: Explicitly skip @requires module in PHPUnit Kernel and Browser tests.