The search form redirect destination should never by overridden by any static destination set in the request.

Earlier a patch was applied to search_box_form_submit(), this patch should also be applied to search_form_submit()

CommentFileSizeAuthor
#3 search-force-destination-2634146-3.d7.patch727 byteshpbruna
search-force-destination.d7.patch727 byteshpbruna

Comments

hpbruna created an issue. See original summary.

Status: Needs review » Needs work

The last submitted patch, search-force-destination.d7.patch, failed testing.

hpbruna’s picture

hpbruna commented
StatusFileSize
new search-force-destination-2634146-3.d7.patch727 bytes

patch for dev now

hpbruna’s picture

hpbruna commented
Status: Needs work » Needs review
jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Postponed (maintainer needs more info)
Issue tags: +Needs tests

Thanks for the issue and patch!

So, before we can add this patch to Drupal Core, we would need a test for the problem. Your issue did not even include steps to reproduce it, so it is difficult to know what will trigger this problem or how to make a test.

Also I am wondering if it is a duplicate of #2530652: Cannot use search block again if error occured in previous search -- does the patch there fix your problem?

So... please:

(a) Test the patch on that other issue and see if it fixes your problem. If so, mark this issue as a duplicate.

(b) If that patch doesn't fix your problem, please provide either an automated test for your problem, or at least some steps to reproduce it so that someone else could write a test. Also a more informative issue title like "When you .... this happens ..." would be better than "force destination" (which describes the patch and not the supposed bug).

(c) Eventually when we have steps to reproduce, we also would need to test this in Drupal 8 and see if it has the same problem. If the problem exists in 8, we would need to patch it there first and then move on to 7.

Thanks!

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Postponed (maintainer needs more info) » Closed (duplicate)

As there has been no response, I am going to assume this is a duplicate of #2530652: Cannot use search block again if error occured in previous search. If that is not the case, please reopen this issue, read comment #5, and provide more information about how to reproduce the problem. Thanks!