Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
migration system
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
3 Dec 2015 at 19:12 UTC
Updated:
6 Jan 2016 at 16:04 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
neclimdulInterdiff from the last patch in parent issue.
Comment #3
neclimdulComment #4
phenaproximaLooks good but I have nits, as I often do...
"Test that various default cases"? :)
I'd like to see a few comments here explaining the input and why the expected output is expected.
There's no explanatory line in the doc comment...
This is repeated in testDefaults(); can it go in setUp()?
Comment #5
neclimdulComment #6
neclimdulthanks, some patches.... and a distracted posting.
Comment #7
quietone commentedFrom a recent learning experience with jhodgdon I've learned that function summary lines start with a third person singular present tense verb. Let's see if I got it right.
s/Test/Tests
Change to something like "Tests that an exception is thrown when the input is not a date field."
Comment #8
quietone commentedFrom IRC discussion with heddn, I've made a new patch to address items in #7.
Comment #9
quietone commentedAnd further from that discussion, IIRC, it was suggested that I could RTBC this after making the small change above.
Comment #10
neclimdulAgreed. Thanks.
Comment #11
alexpottCommitted e145d63 and pushed to 8.0.x and 8.1.x. Thanks!